rustdoc: resolve intra-doc links to builtin macros#61916
Closed
QuietMisdreavus wants to merge 2 commits intorust-lang:masterfrom
Closed
rustdoc: resolve intra-doc links to builtin macros#61916QuietMisdreavus wants to merge 2 commits intorust-lang:masterfrom
QuietMisdreavus wants to merge 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
cc #61877 cc @petrochenkov |
Contributor
Author
|
Oh yikes, that PR is looking to remove |
Contributor
|
@QuietMisdreavus Can you not use |
Contributor
Author
|
I'd still have to rework the PR - one of the checks in this PR happens after the resolver is gone. And since rustdoc only saves |
Contributor
Author
Contributor
|
Closing as superseded by #62086. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61804
When rustdoc encounters an intra-doc link that resolves to a built-in macro, it attempts to load up the crate's name as it saves the information about the link target. However, this causes an ICE since the built-in macros don't come from a regular crate. This PR attempts to work around this by handling built-in macros separately, similarly to how it handles primitives - by linking to the standard library's documentation, where there are documentation stubs available to link against.