Remove io::Result from syntax::print#62099
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors try for perf |
|
⌛ Trying commit 08c6ef101f8fb552f80f1644056176f72cd0593c with merge 7ab25a8e9285302ebc2e6bb5bb02fa0d191d424d... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
08c6ef1 to
32e5de9
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
32e5de9 to
0e9958e
Compare
|
@bors try |
|
⌛ Trying commit 0e9958e7a2914b634a6ebf1fc8342bab2f8e2755 with merge c81fc323f8dab75a771421438e9aeddd8be1b476... |
|
☀️ Try build successful - checks-travis |
|
@rust-timer build c81fc323f8dab75a771421438e9aeddd8be1b476 |
|
Success: Queued c81fc323f8dab75a771421438e9aeddd8be1b476 with parent 7e08576, comparison URL. |
|
Finished benchmarking try commit c81fc323f8dab75a771421438e9aeddd8be1b476, comparison URL. |
|
If possible, I'd prefer if |
|
Why was |
|
Should we close #62098 and merge this instead? |
|
This is only split off because of the large diff in the last commit; we can merge just it or separately, doesn't matter to me. I only chose Vec because it was what we were already passing in, I'll work on replacing it with String. Should be very simple. |
0e9958e to
ada9cc0
Compare
|
I've gone ahead and closed #62098; this is updated with the code using |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ada9cc0 to
d2b3117
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Since we're now writing directly to the vector, there's no need to thread results through the whole printing infrastructure
15d6d19 to
d26c4b7
Compare
|
@bors r+ |
|
📌 Commit d26c4b7 has been approved by |
|
@bors rollup=never |
…2, r=eddyb Remove io::Result from syntax::print Since we're now writing directly to the vector, there's no need to thread results through the whole printing infrastructure
Remove io::Result from syntax::print Since we're now writing directly to the vector, there's no need to thread results through the whole printing infrastructure
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
Tested on commit rust-lang/rust@f119bf2. Direct link to PR: <rust-lang/rust#62099> 💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
Since we're now writing directly to the vector, there's no need to
thread results through the whole printing infrastructure