Closed
Conversation
Co-Authored-By: Taiki Endo <te316e89@gmail.com> Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com> Co-Authored-By: Torbjørn Birch Moltu <t.b.moltu@lyse.net>
Lexer uses Symbols for a lot of stuff, not only for identifiers, so the "name" terminology is just confusing.
…tsakis Update new_debug_unreachable In latest master, smallvec has been updated. So we only update new_debug_unreachable to remove unmaintained dependencies.
Remove `FnBox` Remove `FnBox` since we now have `Box<dyn FnOnce>`. Closes rust-lang#28796. r? @cramertj
Updated RELEASES.md for 1.36.0 [Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release
call out explicitly that general read needs to be called with an initialized buffer
Add debug assertions to write_bytes and copy* Looks like @nitnelave went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship. Cc rust-lang#53871
Inform the query system about properties of queries at compile time
Add more tests for async/await I'll follow up with more of these, but here's an initial few. r? @Centril
refactor lexer to use idiomatic borrowing
Contributor
Author
|
@bors r+ p=8 rollup=never |
1 similar comment
Contributor
Author
|
@bors r+ p=8 rollup=never |
Collaborator
|
📌 Commit 608377c has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened |
Collaborator
|
⌛ Testing commit 608377c with merge 235e6e815135f71d45955381589a2d889cb5d8cc... |
Collaborator
|
💔 Test failed - checks-travis |
Contributor
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
FnBox#62043 (RemoveFnBox)Failed merges:
r? @ghost