Move some tests in src/test/compile-fail -> src/test/ui#62177
Move some tests in src/test/compile-fail -> src/test/ui#62177Centril wants to merge 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Yay! Initial tests seem to pass at least. |
|
Some of these are going to fail on wasm, IIRC. |
petrochenkov
added
S-waiting-on-author
|
r=me after the wasm check |
@petrochenkov Will do. Should I ignore tests for the wasm target if they fail? |
|
Splitting into |
|
(Since they "fail" by producing platform-dependent output, rather than by really failing.) |
Centril
force-pushed
the
move-some-compile-fail-tests
branch
from
477fb6c to
6d4c642
Compare
|
Tested wasm with @bors r=petrochenkov |
|
📌 Commit 6d4c642 has been approved by |
bors
added
S-waiting-on-bors
|
|
||
| error[E0463]: can't find crate for `std` | ||
| | | ||
| = note: the `wasm32-unknown-unknown` target may not be installed |
There was a problem hiding this comment.
You could also use normalization to get rid of these two lines. Then you don't need to duplicate tests.
There was a problem hiding this comment.
I have e.g. used the following to normalize away entire lines in other tests:
// normalize-stderr-test "thread.*panicked.*Metadata module not compiled.*\n" -> ""
// normalize-stderr-test "note:.*RUST_BACKTRACE=1.*\n" -> ""
There was a problem hiding this comment.
Hm, this is great news.
For some reason I thought the normalization works per-line.
There was a problem hiding this comment.
Much simpler to fix platform-dependent tests this way.
There was a problem hiding this comment.
I think the matching of the normalization pattern is per-line -- but if you include the final \n, you can remove the entire line. And then that's handled correctly when comparing later.
There was a problem hiding this comment.
I'll have a look at this tomorrow; in the meantime feel free to r- or we can do this in a follow up PR if that's alright with y'all.
…s, r=petrochenkov Move some tests in src/test/compile-fail -> src/test/ui This is a subset of rust-lang#62113. Hopefully everything here sticks, but if it doesn't I'll remove tests until it does. r? @petrochenkov
|
@bors r- Failed in #62294 (comment). Will try the normalization strategy instead. |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #62355) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@Centril Ping from triage regarding the merge conflicts! :) |
|
@Centril @petrochenkov Ping from triage, this is so close! :) |
|
Third ping from triage, @Centril any updates on this? Note: Thanks for the PR. This will be closed and marked as Thanks |
|
Closing for now until I have time to get back to it :) |
8 participants
This is a subset of #62113.
Hopefully everything here sticks, but if it doesn't I'll remove tests until it does.
r? @petrochenkov