Closed
Conversation
Fix a typo in `libcore/char/methods.rs`
…tsakis Update new_debug_unreachable In latest master, smallvec has been updated. So we only update new_debug_unreachable to remove unmaintained dependencies.
…thewjasper Adjust warning of -C extra-filename with -o. If `--emit` includes multiple unnamed outputs, and `-o` was specified, and `-C extra-filename` was specified, the compiler would warn that `-C extra-filename` was ignored, but this is not true. The "adapting" of the filenames includes the extra-filename info. Since this is a little convoluted and hard to follow, here is a little chart to summarize when running with `rustc foo.rs -o xyz -C extra-filename=asdf` `--emit` | Result ---------|-------- `link` | `xyz` (extra-filename ignored) `link,dep-info` | `xyzasdf`, `xyzasdf.d` (this PR removes the incorrect warning) As to whether or not this behavior is the best choice is another question.
…omez rustdoc: remove unused derives and variants Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too. r? @GuillaumeGomez
…entril Extend the `#[must_use]` lint to arrays Based on top of rust-lang#62228. r? @Centril
…kennytm Fix a typo The definition of 京 seems to be capital, but not capitol. [reference](https://en.wiktionary.org/wiki/%E4%BA%AC#Etymology_1) [another reference](https://jisho.org/word/%E4%BA%AC)
Contributor
Author
|
@bors r+ p=5 rollup=never |
Collaborator
|
📌 Commit f58e80f has been approved by |
Collaborator
|
⌛ Testing commit f58e80f with merge 6338ca593d36f4eb575772d9e7257e2a2f1c9b23... |
Collaborator
|
💔 Test failed - checks-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[must_use]lint to arrays #62235 (Extend the#[must_use]lint to arrays)Failed merges:
r? @ghost