Closed
Conversation
Given
```
mented on Jan 26, 2015 •
trait Foo { fn method(&self) {} }
fn call_method<T>(x: &T) {
x.method()
}
```
suggest constraining `T` with `Foo`.
Affect is usually used as a verb, effect as a verb.
This reverts commit 42d652e.
I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!
…iper Test that maplike FromIter satisfies uniqueness This PR adds a simple assertion to the `HashMap` and `HashSet` tests to ensure that uniqueness is satisfied when `FromIter`ing. This is useful for people who want to test their custom type against the Map/Set interfaces since they'll copy the tests wholesale but possibly miss this bug (where _they_ = _me_).
do not use assume_init in std::io Cc rust-lang#62397
Suggest trait bound on type parameter when it is unconstrained
Given
```
trait Foo { fn method(&self) {} }
fn call_method<T>(x: &T) {
x.method()
}
```
suggest constraining `T` with `Foo`.
Fix rust-lang#21673, fix rust-lang#41030.
Fix typo in src/libstd/net/udp.rs doc comment Affect is usually used as a verb, effect as a verb.
…_compiler_messages_p9, r=Centril normalize use of backticks in compiler messages for libcore/ptr rust-lang#60532
…enkov Handle more cases of typos misinterpreted as type ascription Fix rust-lang#60933, rust-lang#54516. CC rust-lang#47666, rust-lang#34255, rust-lang#48016.
… r=eddyb rustc_typeck: improve diagnostics for _ const/static declarations This continues rust-lang#62694 and adds type suggestions to const/static declarations with `_` type. r? @eddyb
Revert "Disable stack probing for gnux32." This reverts commit 42d652e. (rust-lang#59686) Closes rust-lang#59674.
…_compiler_messages_p11, r=GuillaumeGomez normalize use of backticks in compiler messages for librustc_metadata rust-lang#60532
…ulacrum rustc: Compile the `fmt_macros` crate as an rlib I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!
…_compiler_messages_p12, r=Centril normalize use of backticks in compiler messages for librustc_incremental rust-lang#60532
Contributor
Author
|
@bors r+ p=11 rollup=never |
Collaborator
|
📌 Commit 6558b98 has been approved by |
Collaborator
|
⌛ Testing commit 6558b98 with merge fd584a066edde978d593300b0918dfa700e9c531... |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
|
Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
fmt_macroscrate as an rlib #62813 (rustc: Compile thefmt_macroscrate as an rlib)Failed merges:
r? @ghost