diagnostics: Describe crate root modules in DefKind::Mod as "crate"#63250
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 11, 2019
Merged
diagnostics: Describe crate root modules in DefKind::Mod as "crate"#63250bors merged 2 commits intorust-lang:masterfrom
DefKind::Mod as "crate"#63250bors merged 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
davidtwco
approved these changes
Aug 4, 2019
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Looks good to me! One or two of the changes are minor regressions (IMO - some of the changes from extern crate to crate) but overall I think this is an improvement.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 50b258b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 5, 2019
diagnostics: Describe crate root modules in `DefKind::Mod` as "crate" Or we can use "extern crate" like resolve previously did sometimes, not sure. r? @davidtwco
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
diagnostics: Describe crate root modules in `DefKind::Mod` as "crate" Or we can use "extern crate" like resolve previously did sometimes, not sure. r? @davidtwco
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
diagnostics: Describe crate root modules in `DefKind::Mod` as "crate" Or we can use "extern crate" like resolve previously did sometimes, not sure. r? @davidtwco
Contributor
|
Failed in #63318 (comment) (due to cargo making assumption about error message; see https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/5242/logs/1000). @bors r- |
bors
added
S-waiting-on-author
Contributor
Author
|
Blocked on rust-lang/cargo#7231. |
petrochenkov
added
S-blocked
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Aug 9, 2019
Update two tests for changes in rustc output Required for landing rust-lang/rust#63250. (I'm not sure what is the process for landing synchronous changes like this.)
Collaborator
|
☔ The latest upstream changes (presumably #63428) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
added
S-blocked
Contributor
Author
|
Blocked on #63400. |
Contributor
Author
|
@bors r=davidtwco |
Collaborator
|
📌 Commit 26d26eb has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
Cargo updated. |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 10, 2019
diagnostics: Describe crate root modules in `DefKind::Mod` as "crate" Or we can use "extern crate" like resolve previously did sometimes, not sure. r? @davidtwco
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or we can use "extern crate" like resolve previously did sometimes, not sure.
r? @davidtwco