Conversation
In `configure.py`, using the `o` function creates an enable/disable boolean setting, and writes `true` or `false` in `config.toml`. However, rustbuild is expecting to parse a `u32` debuginfo level. We can change to the `v` function to have the options require a value.
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
…me-elision-2-beta, r=Centril
Member
Author
|
@bors r+ p=10 |
Collaborator
|
📌 Commit d612ffcf3d3b0d3a76fe83425742ee03193be058 has been approved by |
Collaborator
|
⌛ Testing commit d612ffcf3d3b0d3a76fe83425742ee03193be058 with merge f946d3e4bcae26f60607513ca7f0049da15095f7... |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
d612ffc to
775ffd9
Compare
Member
Author
|
@bors r+ p=10 |
Collaborator
|
📌 Commit 775ffd9 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 5, 2019
[beta] Rollup backports Cherry picked: * Updated RELEASES.md for 1.37.0 #63147 * Require a value for configure --debuginfo-level #62906 * Make the parser TokenStream more resilient after mismatched delimiter recovery #62887 * ci: move .azure-pipelines to src/ci/azure-pipelines #63242 Rolled up: * [BETA] Update cargo #62911 * [beta] Backport #61207 #63254 r? @ghost
Collaborator
|
☀️ Test successful - checks-azure |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked:
Rolled up:
Pin<&(mut) Self>#61207 [beta] Backport #61207 #63254r? @ghost