Restore the rustc_plugin crate in the sysroot#63736
Conversation
It was accidentally removed in a rebase of rust-lang#62727 Fixes rust-lang#63729
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors p=5 for tool fix, landing ideally before the next Nightly |
|
@bors r+ |
|
📌 Commit c561abe has been approved by |
bors
added
S-waiting-on-bors
|
Setting p=5 on PRs just because of tool updates just messes with my ability to manage the queue; @bors p=0 |
Restore the rustc_plugin crate in the sysroot It was accidentally removed in a rebase of rust-lang#62727 Fixes rust-lang#63729 (rls build failure)
|
Sorry, is queue management etiquette documented somewhere? |
|
I don't believe so. |
|
It doesn’t seem reasonable to expect people to follow unwritten rules they have no way to be aware of. |
|
@SimonSapin Just don't assign random high priorities unless there's a high degree of urgency (e.g. a stabilization PR where we are closed to the master=>beta cutoff, some CI problem that must be fixed immediately, or making a new release) (and tool updates missing a nightly are not urgent). If you want to signal that something is a bit important then use |
Missing RLS should be considered a high degree of urgency. |
Restore the rustc_plugin crate in the sysroot It was accidentally removed in a rebase of rust-lang#62727 Fixes rust-lang#63729 (rls build failure)
Restore the rustc_plugin crate in the sysroot It was accidentally removed in a rebase of rust-lang#62727 Fixes rust-lang#63729 (rls build failure)
Rollup of 7 pull requests Successful merges: - #63216 (avoid unnecessary reservations in std::io::Take::read_to_end) - #63265 (Implement `nth_back` for ChunksExactMut) - #63691 (Fix bug in iter::Chain::size_hint) - #63722 (Don't use stage naming in RUSTFLAGS environment variables) - #63723 (Consolidate sigemptyset workarounds) - #63736 (Restore the rustc_plugin crate in the sysroot) - #63743 (Allow git to merge `Cargo.lock`) Failed merges: r? @ghost
8 participants
It was accidentally removed in a rebase of #62727
Fixes #63729 (rls build failure)