Allow checking of run-pass execution output in compiletest#63825
Merged
bors merged 7 commits intorust-lang:masterfrom Sep 4, 2019
Merged
Allow checking of run-pass execution output in compiletest#63825bors merged 7 commits intorust-lang:masterfrom
bors merged 7 commits intorust-lang:masterfrom
Conversation
Moved into ```fn load_compare_outputs(&self, proc_res: &ProcRes, explicit_format: bool) -> usize```
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
Member
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
Thanks! A few comments, but this looks good overall.
nathanwhit
force-pushed
the
check-run-results
branch
from
457bfce to
3dc3cf3
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nathanwhit
force-pushed
the
check-run-results
branch
from
3dc3cf3 to
1c6b986
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nathanwhit
force-pushed
the
check-run-results
branch
from
1c6b986 to
29cc305
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nathanwhit
force-pushed
the
check-run-results
branch
from
29cc305 to
cdf3beb
Compare
Member
Collaborator
|
📌 Commit cdf3beb178dd6ae8eabb7519b6b7007e8d30e19a has been approved by |
bors
added
S-waiting-on-bors
RalfJung
reviewed
Aug 28, 2019
Collaborator
|
⌛ Testing commit cdf3beb178dd6ae8eabb7519b6b7007e8d30e19a with merge f970d3d042fcb718c2ab908190bf0cbbb47a8271... |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Member
|
Hm, this makes them "pass" on that platform though, instead of being marked as "ignored" as it probably should. |
Member
|
Yeah, I'd rather we didn't mark them as having passed. |
Contributor
Author
|
Okay, I'll go ahead and make that change. |
Ignores run-pass tests with the `check-run-results` flag enabled for the
wasm32-bare ("wasm32-unknown-unknown") target, as it does not support
printing to stdout/stderr.
nathanwhit
force-pushed
the
check-run-results
branch
from
e86d112 to
bf44f12
Compare
Member
|
Yeah, I think it's a bit ambiguous as to what the correct behavior there is but overall I'd prefer to ignore the test entirely I think. We can of course change that at a later point. @bors r+ |
Collaborator
|
📌 Commit bf44f12 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Sep 3, 2019
Allow checking of run-pass execution output in compiletest Closes #63751 Adds a `check-run-results` flag to compiletest headers, which if enabled checks the output of the execution of a run-pass test's binary against expected output.
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
The remote-test-client outputs a message of the form "uploaded "<build_dir>/<executable_path>", waiting for result" onto stdout when executing a test, which is then captured in the process result. This needs to be removed when comparing the results of the run-pass test execution.
Contributor
Author
|
The most recent commit should take care of the failing test, and allow for the PR to merge. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 12adc39 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Sep 4, 2019
Allow checking of run-pass execution output in compiletest Closes #63751 Adds a `check-run-results` flag to compiletest headers, which if enabled checks the output of the execution of a run-pass test's binary against expected output.
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63751
Adds a
check-run-resultsflag to compiletest headers, which if enabled checks the output of the execution of a run-pass test's binary against expected output.