Suggest call fn ctor passed as arg to fn with type param bounds#63870
Merged
bors merged 6 commits intorust-lang:masterfrom Sep 1, 2019
Merged
Suggest call fn ctor passed as arg to fn with type param bounds#63870bors merged 6 commits intorust-lang:masterfrom
bors merged 6 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
Future work: keep accurate obligation spans for type bounds associated to specific fn arguments to point at the argument instead of the ident of the fn call. CC @oli-obk |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
async-fn-call
branch
from
928e528 to
3129bc8
Compare
Patryk27
reviewed
Aug 25, 2019
killercup
reviewed
Aug 25, 2019
Contributor
Author
|
ping |
oli-obk
reviewed
Aug 30, 2019
Contributor
There was a problem hiding this comment.
In case anyone is wondering why this is not a suggestion on foo's span: the error itself is already wrongly highlighting the bar function instead of its foo argument. That's a longstanding issue, but we have some ideas on how to continue with it.
Contributor
Collaborator
|
📌 Commit eb21c09edd79cb46625ca2f633dbe5fd7eee55b6 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit eb21c09edd79cb46625ca2f633dbe5fd7eee55b6 with merge 9e2c72f0c0fc8b9cc8c8dc738b1b92277fddcbc8... |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry 😅 |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit eb21c09edd79cb46625ca2f633dbe5fd7eee55b6 with merge 544cc59e7f4607dc9f061b849cef01a1fe4edba3... |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit ae93fa90a8f1d899372a0251dc6110f9b971cd1e has been approved by |
Collaborator
|
⌛ Testing commit ae93fa90a8f1d899372a0251dc6110f9b971cd1e with merge 4e180593b75b6fc0a1fb8ec6c3146ab6ef05b389... |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
estebank
force-pushed
the
async-fn-call
branch
from
ae93fa9 to
e553051
Compare
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit e553051 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Sep 1, 2019
Suggest call fn ctor passed as arg to fn with type param bounds
_Reviewer note: the relevant changes are in the second commit, the first is simple and mechanical, but verbose._
When forgetting to call a fn in an argument position to an fn that has a generic bound:
```rust
async fn foo() {}
fn bar(f: impl Future<Output=()>) {}
fn main() {
bar(foo); // <- should be `bar(foo());`
}
```
suggest calling it:
```
error[E0277]: the trait bound `fn() -> impl std::future::Future {foo}: std::future::Future` is not satisfied
--> $DIR/async-fn-ctor-passed-as-arg-where-it-should-have-been-called.rs:9:5
|
LL | fn bar(f: impl Future<Output=()>) {}
| --------------------------------- required by `bar`
...
LL | bar(foo);
| ^^^ the trait `std::future::Future` is not implemented for `fn() -> impl std::future::Future {foo}`
|
= help: it looks like you forgot to use parentheses to call the function: `foo()`
```
Fix #63100. Follow up to #63833 and #63337.
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer note: the relevant changes are in the second commit, the first is simple and mechanical, but verbose.
When forgetting to call a fn in an argument position to an fn that has a generic bound:
suggest calling it:
Fix #63100. Follow up to #63833 and #63337.