Harden param_attrs test wrt. usage of a proc macro #[attr]#64031
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 5, 2019
Merged
Harden param_attrs test wrt. usage of a proc macro #[attr]#64031bors merged 1 commit intorust-lang:masterfrom
param_attrs test wrt. usage of a proc macro #[attr]#64031bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
| use proc_macro::TokenStream; | ||
|
|
||
| #[proc_macro_attribute] | ||
| pub fn id(_: TokenStream, input: TokenStream) -> TokenStream { input } |
Contributor
There was a problem hiding this comment.
We have auxiliary/test-macros.rs that defines all the utility macros like this, you can use #[identity_attr] from there.
Contributor
Author
There was a problem hiding this comment.
I'd have to move the test, right?
Contributor
There was a problem hiding this comment.
Ah, ok then.
(We need a way to use a crate from the root auxiliary directory in all subdirectories to avoid duplication.)
Contributor
|
( |
Contributor
Author
|
(Yeah, fair point. I suppose the test can serve as accident prevention for possibly weird changes but those would be unlikely. I'll leave it to Niko to decide whether they feel this would be beneficial. I think it need not block stabilization in either case.) |
Contributor
|
@bors rollup r+ |
Collaborator
|
📌 Commit 5187a3e has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
Seems good to test a "user-provided" proc macro regardless |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 5, 2019
… r=nikomatsakis Harden `param_attrs` test wrt. usage of a proc macro `#[attr]` The `param-attrs-builtin-attrs.rs` test file uses the `#[test]` attribute which should cover this but `#[test]` isn't a proc macro attribute so we add another test to be on the safe side. This intends to address rust-lang#64010 (comment). r? @nikomatsakis cc @c410-f3r @petrochenkov cc rust-lang#60406
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 5, 2019
… r=nikomatsakis Harden `param_attrs` test wrt. usage of a proc macro `#[attr]` The `param-attrs-builtin-attrs.rs` test file uses the `#[test]` attribute which should cover this but `#[test]` isn't a proc macro attribute so we add another test to be on the safe side. This intends to address rust-lang#64010 (comment). r? @nikomatsakis cc @c410-f3r @petrochenkov cc rust-lang#60406
bors
added a commit
that referenced
this pull request
Sep 5, 2019
Rollup of 15 pull requests Successful merges: - #62860 (Stabilize checked_duration_since for 1.38.0) - #63549 (Rev::rposition counts from the wrong end) - #63985 (Stabilize pin_into_inner in 1.39.0) - #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection) - #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`) - #64038 (Check impl trait substs when checking for recursive types) - #64043 (Add some more tests for underscore imports) - #64092 (Update xLTO compatibility table in rustc book.) - #64110 (Refer to "`self` type" instead of "receiver type") - #64120 (Move path parsing earlier) - #64123 (Added warning around code with reference to uninit bytes) - #64128 (unused_parens: account for or-patterns and `&(mut x)`) - #64141 (Minimize uses of `LocalInternedString`) - #64142 (Fix doc links in `std::cmp` module) - #64148 (fix a few typos in comments) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
param-attrs-builtin-attrs.rstest file uses the#[test]attribute which should cover this but#[test]isn't a proc macro attribute so we add another test to be on the safe side. This intends to address #64010 (comment).r? @nikomatsakis
cc @c410-f3r @petrochenkov
cc #60406