[WIP] Crater rollup of 3 PRs (#63809, #63812, #63831).

[eddyb]

I've combined my 3 PRs in the crater queue:

• [WIP] proc_macro: check non-interned handles for "leaks" between/after invocations. #63809 proc_macro: check non-interned handles for "leaks" between/after invocations.
• rustc_mir: double-check const-promotion candidates for sanity. #63812 rustc_mir: double-check const-promotion candidates for sanity.
• [WIP] rustc_mir: disallow global mutable state in proc macros. #63831 rustc_mir: disallow global mutable state in proc macros.

cc @pietroalbini @Mark-Simulacrum Is this a good idea?

[rust-highfive]

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

@bors try

[bors]

⌛ Trying commit b760987 with merge e689e5eaefe96e6dc3ed5bb629c521b7d207aff7...

[bors]

☀️ Try build successful - checks-azure
Build commit: e689e5eaefe96e6dc3ed5bb629c521b7d207aff7

[eddyb]

@craterbot run mode=check-only p=1 crates=full

[craterbot]

👌 Experiment pr-64398 created and queued.
🤖 Automatically detected try build e689e5eaefe96e6dc3ed5bb629c521b7d207aff7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-64398 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-64398 is completed!
📊 656 regressed and 0 fixed (74234 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[petrochenkov]

Marking as waiting-on-author to triage the regressions.

[eddyb]

By quickly grepping the regressed.tar.gz (thanks for the idea, @oli-obk!):

• 652 error: mutable global state in a proc-macro ([WIP] rustc_mir: disallow global mutable state in proc macros. #63831)
  • haven't triaged them yet, many appear legitimate (immutable lazy_static!s)
  • EDIT: it would be hard to triage the lazy_static!s without augmenting the check to look inside the lazy_static abstraction for !Freeze
  • EDIT: auto_impl and rtti-derive appear to keep proc_macro objects in global state, while a few other crates (e.g. auto-enum{,erate}) use global state for counters/RNGs
  • EDIT: core: Remove usage of mutable global state taiki-e/auto_enums#60 fixes one instance of this
• 3 proc_macro handles were leaked panics ([WIP] proc_macro: check non-interned handles for "leaks" between/after invocations. #63809)
  • 2 of them would be fixed by Don't leak a TokenStream in Ctxt::emit_errors. tesaguri/oauth1-request-rs#2
  • EDIT: the 3rd appears to be from ref-counting cycles
  • could also include any of the above 652 regressions - though not lazy_static! ones
    • EDIT: found at least one example in auto_impl, so we need another crater run
• 1 LLVM ERROR: IO failure on output stream: Cannot allocate memory (spurious?)
• 0 assertion failures from MIR const checking (rustc_mir: double-check const-promotion candidates for sanity. #63812)
  • could also include any of the 656 regressions, but unlikely

[petrochenkov]

Crater completed, so closing in favor of the original PRs.