Closed
Conversation
It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
* Serialize the level to something a little more useful for a failure note struct * Update tests accordingly
Co-Authored-By: Ralf Jung <post@ralfj.de>
Get rid of special const intrinsic query in favour of `const_eval` r? @eddyb
… r=Mark-Simulacrum Shrink `SubregionOrigin`. It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
…json-level, r=Mark-Simulacrum Fix failure note `to_str` implementation Serialize the level to something a little more useful for a failure note struct. This fixes rust-lang#60425.
improve Vec example soundness in mem::transmute docs The previous version of the `Vec` example had a case of questionable soundness, because at one point `v_orig` was aliased. r? @RalfJung
…bini avoid duplicate issues for Miri build failures Currently, when Miri regressed from test-pass to test-fail, we pen an issue -- and then when it regresses further from test-fail to build-fail, we open a *second* issue. This changes the logic to avoid the redundant second issue for Miri. r? @pietroalbini @kennytm
Add an example to Pin::as_mut taiki-e/pin-project#89 (comment) r? @RalfJung
document Miri error categories r? @oli-obk
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
Member
Author
|
@bors r+ p=8 |
Collaborator
|
📌 Commit b7e4677 has been approved by |
bors
added
the
S-waiting-on-bors
Member
Author
bors
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_eval#61626 (Get rid of special const intrinsic query in favour ofconst_eval)SubregionOrigin. #64394 (ShrinkSubregionOrigin.)to_strimplementation #64429 (Fix failure noteto_strimplementation)Failed merges:
r? @ghost