Replace ClosureSubsts with SubstsRef#64817
Merged
bors merged 4 commits intorust-lang:masterfrom Oct 4, 2019
Merged
Conversation
csmoe
changed the title
(TypeCore, Substs) pair
csmoe
added
the
S-waiting-on-review
bjorn3
reviewed
Sep 27, 2019
csmoe
force-pushed
the
closure
branch
2 times, most recently
from
c42ebea to
8ad7407
Compare
Collaborator
|
☔ The latest upstream changes (presumably #64886) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
requested changes
Oct 1, 2019
csmoe
force-pushed
the
closure
branch
17 times, most recently
from
6183c5a to
0dd0395
Compare
nikomatsakis
requested changes
Oct 3, 2019
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
Thanks @csmoe! A few more thoughts.
csmoe
force-pushed
the
closure
branch
9 times, most recently
from
3631fa6 to
bb3df5a
Compare
nikomatsakis
requested changes
Oct 3, 2019
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
OK! This is looking really good. One last request, @csmoe, and thanks <3
csmoe
force-pushed
the
closure
branch
4 times, most recently
from
624a3a1 to
16e4c49
Compare
nikomatsakis
approved these changes
Oct 3, 2019
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 9b91bef has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 4, 2019
Replace ClosureSubsts with SubstsRef Addresses rust-lang#42340 part 3 rust-lang#59312 might benefit from this clean up. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Oct 4, 2019
Rollup of 5 pull requests Successful merges: - #64749 (Fix most remaining Polonius test differences) - #64817 (Replace ClosureSubsts with SubstsRef) - #64874 (Simplify ExprUseVisitor) - #65026 (metadata: Some crate loading cleanup) - #65073 (Remove `borrowck_graphviz_postflow` from test) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #42340 part 3
#59312 might benefit from this clean up.
r? @nikomatsakis