[const-prop] Handle remaining MIR Rvalue cases#64890
Merged
bors merged 7 commits intorust-lang:masterfrom Oct 19, 2019
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Sep 29, 2019
oli-obk
reviewed
Sep 29, 2019
wesleywiser
force-pushed
the
const_prop_rvalue
branch
2 times, most recently
from
d8549cb to
4982dae
Compare
oli-obk
reviewed
Sep 30, 2019
Contributor
|
just a formatting nit, then this lgtm. |
wesleywiser
force-pushed
the
const_prop_rvalue
branch
2 times, most recently
from
c3cdb89 to
5804c3b
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 5804c3b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 1, 2019
…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 1, 2019
…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 1, 2019
…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk
Contributor
|
(Speculation) Failed in #64955 (comment), @bors r- |
bors
added
S-waiting-on-author
Member
|
Assertion location: rust/src/librustc_mir/interpret/place.rs Line 1032 in 702b45e |
|
Ping from Triage: any updates @wesleywiser? |
Member
Author
|
Got married this weekend; I'll probably get back to this later this week :) |
Member
Author
|
@oli-obk Pushed a fix. Let me know what you think. |
bors
added
S-waiting-on-review
Member
Author
|
A mir-opt test I added failed because wasm doesn't support unwinding. I'll fix this tonight. |
wesleywiser
force-pushed
the
const_prop_rvalue
branch
from
883148b to
fd20dbe
Compare
Member
Author
|
Added ignore-{wasm,enscripten} to the box test. @bors r=oli-obk |
Collaborator
|
📌 Commit fd20dbe has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit fd20dbe with merge bf46d1b81e0f1be41abd66dabb21515f6d0bfdc7... |
Contributor
|
@bors rollup=never retry yielding to r0llup |
Collaborator
|
⌛ Testing commit fd20dbe with merge 662301e2a9170f3aba36b6f4df7fec1309606866... |
Contributor
|
@bors retry yielding to r0llup |
Collaborator
bors
added a commit
that referenced
this pull request
Oct 19, 2019
[const-prop] Handle remaining MIR Rvalue cases r? @oli-obk
Collaborator
|
☀️ Test successful - checks-azure |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 20, 2019
…eywiser clarify const_prop ICE protection comment This is based on discussion at https://github.com/rust-lang/rust/pull/64890/files#r334555787. That said, why are function arguments the only unsized locals that could remain uninitialized? Couldn't we also fail to initialize some local but still go on with const_prop, and then hit a line that takes a reference to that? Cc @wesleywiser @oli-obk ; I don't know enough about const-prop to understand why this can happen only for function arguments. ~~The PR includes rust-lang#64890; the only new commit is 05e4e6ba0d5.~~
bors
added a commit
that referenced
this pull request
Oct 30, 2019
…<try> [mir-opt] Implement pass to remove branches on uninhabited variants Based on discussion [here](#64890 (comment)), this is a pass to eliminate dead code that is caused by branching on an enum with uninhabited variants. r? @oli-obk
bors
added a commit
that referenced
this pull request
Nov 9, 2019
…oli-obk [mir-opt] Implement pass to remove branches on uninhabited variants Based on discussion [here](#64890 (comment)), this is a pass to eliminate dead code that is caused by branching on an enum with uninhabited variants. r? @oli-obk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk