Improve docs on some char boolean methods#65165
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
Ping from triage thanks |
varkor
reviewed
Oct 12, 2019
Contributor
varkor
left a comment
varkor
left a comment
There was a problem hiding this comment.
Looks good to me. Just a couple of missing commas.
Contributor
|
Thanks! @bors r+ rollup |
Collaborator
|
📌 Commit d8c2956 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 13, 2019
Improve docs on some char boolean methods simple revival of rust-lang#61794 (also rustfmt on rest of file :) Documentation for `is_xid_start()` and `is_xid_continue()` couldn't be improved since both methods got remove from this repository r? @dtolnay cc @JohnCSimon
bors
added a commit
that referenced
this pull request
Oct 13, 2019
Rollup of 13 pull requests Successful merges: - #65039 (Document missing deny by default lints) - #65069 (Implement Clone::clone_from for VecDeque) - #65165 (Improve docs on some char boolean methods) - #65248 (Suggest `if let` on `let` refutable binding) - #65250 (resolve: fix error title regarding private constructors) - #65295 (Move diagnostics code out of the critical path) - #65320 (Report `CONST_ERR` lint in external macros) - #65327 (replace the hand-written binary search with the library one) - #65339 (do not reference LLVM for our concurrency memory model) - #65357 (syntax: simplify maybe_annotate_with_ascription) - #65358 (simplify maybe_stage_features) - #65359 (simplify integer_lit) - #65360 (mbe: reduce panictry! uses.) Failed merges: r? @ghost
Collaborator
|
☔ The latest upstream changes (presumably #65368) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple revival of #61794
(also rustfmt on rest of file :)
Documentation for
is_xid_start()andis_xid_continue()couldn't be improved since both methods got remove from this repositoryr? @dtolnay
cc @JohnCSimon