Add long error explanation for E0567#65179
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 8, 2019
Merged
Conversation
Contributor
|
Some changes occurred in diagnostic error codes |
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
100 tasks
davidtwco
requested changes
Oct 7, 2019
Member
davidtwco
left a comment
There was a problem hiding this comment.
LGTM, one or two minor suggestions. Happy to approve once we've decided if we want to adopt the suggestions.
930284a to
59573ec
Compare
Member
Author
|
Updated. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 59573eca7d0306432c2035281d0fc9621de9827c has been approved by |
bors
added a commit
that referenced
this pull request
Oct 8, 2019
Rollup of 8 pull requests Successful merges: - #64726 (rewrite documentation for unimplemented! to clarify use) - #65040 (syntax: more cleanups in item and function signature parsing) - #65046 (Make `Cell::new` method come first in documentation) - #65098 (Add long error explanation for E0561) - #65150 (Suggest dereferencing boolean reference when used in 'if' or 'while') - #65154 (Fix const generic arguments not displaying in types mismatch diagnostic) - #65181 (fix bug in folding for constants) - #65187 (use 'invalid argument' for vxWorks) Failed merges: - #65179 (Add long error explanation for E0567) r? @ghost
This comment has been minimized.
This comment has been minimized.
59573ec to
6608e4a
Compare
Member
Author
|
Rebased. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 6608e4a has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 8, 2019
…-E0567, r=davidtwco Add long error explanation for E0567 Part of rust-lang#61137.
bors
added a commit
that referenced
this pull request
Oct 8, 2019
Rollup of 8 pull requests Successful merges: - #64404 (Add long error explanation for E0495) - #64918 (Add long error explanation for E0551) - #65102 (Disable stack probe when thread sanitizer is enabled) - #65120 (Correctly estimate the required space for string in `StyledBuffer::prepend`) - #65145 (When suggesting assoc function with type params, include turbofish) - #65162 (Remove loaded_from_cache map from DepGraph) - #65176 (Remove query-related macros) - #65179 (Add long error explanation for E0567) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #61137.