Add more coherence tests by weiznich · Pull Request #65417 · rust-lang/rust

weiznich · 2019-10-14T21:03:13Z

I've wrote the missing test cases listed in this google doc

The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using.

I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in src/test/ui/coherence or is there something in there that should remain?

cc #63599

r? @nikomatsakis

nikomatsakis · 2019-10-15T18:19:52Z

@weiznich thanks! you rock.

In terms of the existing tests, hmm, I feel like some of them may have covered worthy scenarios outside of the doc. I wouldn't want to remove them without review.

nikomatsakis · 2019-10-17T22:32:44Z

@bors r+ rollup

bors · 2019-10-17T22:32:46Z

📌 Commit 77f0aaf has been approved by nikomatsakis

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

Centril · 2019-10-18T15:23:57Z

The failure in #65550 (comment) may have been spurious and maybe not. Please have a look. :)

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

@ghost

Rollup of 17 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65417 (Add more coherence tests) - #65434 (Add long error explanation for E0577) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65496 (properly document panics in div_euclid and rem_euclid) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65471 (Add long error explanation for E0578) r? @ghost

tmandry · 2019-10-18T20:37:10Z

Failed in #65565 (comment), @bors r-

weiznich · 2019-10-19T06:44:59Z

Seems like the file name of the test is causing that (again 😔). I will fix it as soon as I'm back on my PC.

weiznich · 2019-10-21T20:28:19Z

@tmandry Pushed the (hopefully) the fixes

nikomatsakis · 2019-10-22T18:48:07Z

@bors r+ rollup

@weiznich yeah the file name convention is maybe annoying-- otoh it's so cool to be able to read the test purpose out of the directory listing...

bors · 2019-10-22T18:48:08Z

📌 Commit 7e17ea3 has been approved by nikomatsakis

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

@ghost

Rollup of 14 pull requests Successful merges: - #64145 (Target-feature documented as unsafe) - #65007 (Mention keyword closing policy) - #65417 (Add more coherence tests) - #65507 (Fix test style in unused parentheses lint test) - #65591 (Add long error explanation for E0588) - #65617 (Fix WASI sleep impl) - #65656 (Add option to disable keyboard shortcuts in docs) - #65678 (Add long error explanation for E0728) - #65681 (Code cleanups following up on #65576.) - #65686 (refactor and move `maybe_append` ) - #65688 (Add some tests for fixed ICEs) - #65689 (bring back some Debug instances for Miri) - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.) - #65706 (Add missing space in librustdoc) Failed merges: r? @ghost

rust-highfive assigned nikomatsakis Oct 14, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2019

Add more coherence tests

77f0aaf

weiznich force-pushed the more_coherence_tests branch from 3bff76b to 77f0aaf Compare October 14, 2019 21:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019

Centril mentioned this pull request Oct 17, 2019

Rollup of 7 pull requests #65530

Closed

Centril mentioned this pull request Oct 18, 2019

Rollup of 8 pull requests #65534

Closed

tmandry mentioned this pull request Oct 18, 2019

Rollup of 13 pull requests #65548

Closed

tmandry mentioned this pull request Oct 18, 2019

Rollup of 12 pull requests #65550

Closed

tmandry mentioned this pull request Oct 18, 2019

Rollup of 17 pull requests #65565

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2019

Fix test paths

7e17ea3

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2019

JohnTitor mentioned this pull request Oct 23, 2019

Rollup of 14 pull requests #65716

Merged

bors merged commit 7e17ea3 into rust-lang:master Oct 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add more coherence tests#65417

Add more coherence tests#65417
bors merged 2 commits intorust-lang:masterfrom
weiznich:more_coherence_tests

weiznich commented Oct 14, 2019

Uh oh!

nikomatsakis commented Oct 15, 2019

Uh oh!

nikomatsakis commented Oct 17, 2019

Uh oh!

bors commented Oct 17, 2019

Uh oh!

Centril commented Oct 18, 2019

Uh oh!

tmandry commented Oct 18, 2019

Uh oh!

weiznich commented Oct 19, 2019

Uh oh!

weiznich commented Oct 21, 2019

Uh oh!

nikomatsakis commented Oct 22, 2019

Uh oh!

bors commented Oct 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

weiznich commented Oct 14, 2019

Uh oh!

nikomatsakis commented Oct 15, 2019

Uh oh!

nikomatsakis commented Oct 17, 2019

Uh oh!

bors commented Oct 17, 2019

Uh oh!

Centril commented Oct 18, 2019

Uh oh!

tmandry commented Oct 18, 2019

Uh oh!

weiznich commented Oct 19, 2019

Uh oh!

weiznich commented Oct 21, 2019

Uh oh!

nikomatsakis commented Oct 22, 2019

Uh oh!

bors commented Oct 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants