Add long error explanation for E0577#65434
Conversation
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kinnison
left a comment
There was a problem hiding this comment.
I'm okay with this, though I do have a couple of comments.
src/test/ui/feature-gates/feature-gate-exhaustive-patterns.nll.stderr
Outdated
Show resolved
Hide resolved
|
☔ The latest upstream changes (presumably #65454) made this pull request unmergeable. Please resolve the merge conflicts. |
dc6bb93 to
5500e8e
Compare
|
Updated! |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
5500e8e to
3d88f2c
Compare
|
r? @kinnison |
kinnison
left a comment
There was a problem hiding this comment.
One suggestion left. If you don't want to reword it as much as I suggest, then at least drop the comma after the therefore and after the error words :D
|
@bors: r+ rollup |
|
📌 Commit e417180 has been approved by |
…-E0577, r=Dylan-DPC Add long error explanation for E0577 Part of rust-lang#61137. r? @kinnison
|
@bors: r+ rollup |
|
📌 Commit 4e3f4ca has been approved by |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
f90a8ed to
610ce3f
Compare
|
@bors: r=Dylan-DPC |
|
📌 Commit 610ce3f0ba29625e4f7e60ed0a9397546c782f86 has been approved by |
Rollup of 12 pull requests Successful merges: - #65405 (Create new error E0742 and add long error explanation) - #65539 (resolve: Turn the "non-empty glob must import something" error into a lint) - #65724 (ci: refactor pr tools job skipping) - #65741 (Prevent help popup to disappear when clicking on it) - #65832 (Re-enable Emscripten's exception handling support) - #65843 (Enable dist for MIPS64 musl targets) - #65898 (add basic HermitCore support within libtest) - #65900 (proc_macro: clean up bridge::client::__run_expand{1,2} a bit.) - #65906 (Update mdbook to 0.3.3) - #65920 (Use rustc-workspace-hack for rustbook) - #65930 (doc: use new feature gate for c_void type) - #65936 (save-analysis: Account for async desugaring in async fn return types) Failed merges: - #65434 (Add long error explanation for E0577) r? @ghost
|
☔ The latest upstream changes (presumably #65943) made this pull request unmergeable. Please resolve the merge conflicts. |
610ce3f to
125d60d
Compare
|
And here we go again... @bors: r=Dylan-DPC |
|
📌 Commit 125d60d has been approved by |
…-E0577, r=Dylan-DPC Add long error explanation for E0577 Part of rust-lang#61137. r? @kinnison
Rollup of 7 pull requests Successful merges: - #65274 (Upload toolstates.json to rust-lang-ci2) - #65434 (Add long error explanation for E0577) - #65850 (Update comments re type parameter hack in object safety) - #65955 (ci: revert msys2 ca-certificates hack) - #65959 (Fix an incorrect docstring for Immediate in librustc_mir/interpret.) - #65979 (Switch CrateMetadata's source_map_import_info from RwLock to Once) - #65981 (work around aggressive syntax feature gating) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #65990) made this pull request unmergeable. Please resolve the merge conflicts. |
Part of #61137.
r? @kinnison