Skip to content

Deprecated proc_macro doesn't trigger warning on build library#65484

Closed
XiangQingW wants to merge 0 commit intorust-lang:masterfrom
XiangQingW:proc_macro
Closed

Deprecated proc_macro doesn't trigger warning on build library#65484
XiangQingW wants to merge 0 commit intorust-lang:masterfrom
XiangQingW:proc_macro

Conversation

@XiangQingW
Copy link
Contributor

@XiangQingW XiangQingW commented Oct 17, 2019

Fix #65189

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 17, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2019
@XiangQingW XiangQingW mentioned this pull request Oct 17, 2019
Merged
petrochenkov
petrochenkov reviewed Oct 17, 2019
View reviewed changes
src/libsyntax/ext/build.rs Outdated
Copy link
Contributor

@petrochenkov petrochenkov Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libsyntax/ext/build.rs is kind of deprecated, so it's better to avoid extending it, but rather use attr::mk_nested_word_item and attr::mk_list_item directly in the proc macro harness.

Copy link
Contributor Author

@XiangQingW XiangQingW Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'd love to change it.

@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 17, 2019

This needs a test.
To test this you can copy test/ui/proc-macro/auxiliary/attributes-on-definitions.rs into test/ui/proc-macro and remove unnecessary parts.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
@bors
Copy link
Collaborator

bors commented Oct 17, 2019

☔ The latest upstream changes (presumably #65495) made this pull request unmergeable. Please resolve the merge conflicts.

@joelpalmer
Copy link

joelpalmer commented Oct 21, 2019

Ping from Triage: Hi @XiangQingW, any updates?

@XiangQingW
Copy link
Contributor Author

XiangQingW commented Oct 21, 2019 •
edited
Loading

Ping from Triage: Hi @XiangQingW, any updates?

Yes, I'm working on this. I mess up with conflict and create a new pr ##65666.

@XiangQingW XiangQingW closed this Oct 21, 2019
@petrochenkov petrochenkov mentioned this pull request Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deprecated proc_macro trigger warning on build library

5 participants

@XiangQingW @rust-highfive @petrochenkov @bors @joelpalmer