Closed
Conversation
Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
Also, add a link to the growable type
…e visitors In particular, use a blank visit_place for mutable visitor to be sure, non modified visitors are not trying to mutating place.
This makes the note similar to the one found on rotate functions for primitive types like i32/u32.
Co-Authored-By: Nikita Popov <nikita.ppv@googlemail.com>
Co-Authored-By: Ralf Jung <post@ralfj.de>
…ng,nikic Make <*const/mut T>::offset_from `const fn` This reenables offset_of cc @mjbshaw after rust-lang#63075 broke it
…s2, r=oli-obk Prepare `MutVisitor`s to handle interned projections The following are all the files where mir's `MutVisitor` is implemented. The `-` there stands for no changes, `visit_place` wasn't making any change on `Place`s. `x` stands for this file was changed to make `visit_place` do whatever it was doing with the base but avoid modifying the projection, instead just create a new one and assign to it. ``` [-] src/librustc_mir/transform/no_landing_pads.rs [x] src/librustc_mir/transform/promote_consts.rs [x] src/librustc_mir/transform/generator.rs [x] src/librustc_mir/transform/erase_regions.rs [-] src/librustc_mir/transform/instcombine.rs [x] src/librustc_mir/transform/inline.rs [x] src/librustc_mir/transform/simplify.rs [x] src/librustc_mir/util/def_use.rs [-] src/librustc_mir/transform/const_prop.rs [-] src/librustc_mir/transform/cleanup_post_borrowck.rs [x] src/librustc_mir/borrow_check/nll/renumber.rs [-] src/librustc_mir/transform/copy_prop.rs ``` There is some code repetition, just created the PR so we can start discussing it. /cc @oli-obk @nikomatsakis
Disable Go and OCaml bindings when building LLVM Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.
properly document panics in div_euclid and rem_euclid For signed numbers, document that `div_euclid` and `rem_euclid` panic not just when `rhs` is 0, but also when the division overflows. For unsigned numbers, document that `div_euclid` and `rem_euclid` panic when `rhs` is 0.
…r=simulacrum add option to ping llvm ice-breakers to triagebot
save-analysis: Nest tables when processing impl block definitions Similar to rust-lang#65353 (which this PR should've been a part of), however in this case we didn't previously nest the tables when processing trait paths in impl block declarations. Closes rust-lang#65411
reorder fmt docs for more clarity I adjusted these docs in rust-lang#65332 but wasn't happy with the result when seeing it in rustdoc. So this reorders the subsections in the "Formatting Parameters" section to be more logical (subsections that reference `width` come after the `width` subsection) and they also all have examples now.
doc: make BitSet intro more short Also, add a link to the growable type
show up some extra info when t!() fails
…onas-schievink Fix left/right shift typo in wrapping rotate docs This makes the note similar to the one found on rotate functions for primitive types like i32/u32.
Clarify diagnostics when using `~` as a unary op It seems we prefer `bitwise not` to `bitwise negation`. Fixes rust-lang#57239 r? @estebank
Contributor
Author
|
@bors r+ p=11 rollup=never |
Collaborator
|
📌 Commit 4c317fb has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 4c317fb with merge edb4a20bd1ddb3d132037507dc02c78a8c11ee7d... |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
const fn#63810 (Make <*const/mut T>::offset_fromconst fn)MutVisitors to handle interned projections #65197 (PrepareMutVisitors to handle interned projections)~as a unary op #65552 (Clarify diagnostics when using~as a unary op)Failed merges:
src/llvm-emscriptensubmodule #65501 (Removesrc/llvm-emscriptensubmodule)r? @ghost