Update clippy by msizanoen1 · Pull Request #66142 · rust-lang/rust

msizanoen1 · 2019-11-06T05:18:51Z

Update clippy to latest master to include rust-lang/rust-clippy#4714 which fixes #62558.

Close #62558
r? @Manishearth

rust-highfive · 2019-11-06T05:19:01Z

⚠️ Warning ⚠️

These commits modify submodules.

Manishearth · 2019-11-06T05:52:08Z

@bors r+ p=2

bors · 2019-11-06T05:52:09Z

📌 Commit 1b07d95 has been approved by Manishearth

bors · 2019-11-06T05:54:45Z

⌛ Testing commit 1b07d95 with merge fc38a7d4b1edea08fa14ededee9ec16c77789765...

Centril · 2019-11-06T06:10:34Z

Since #66141 (comment) made Clippy go "test-fail" this PR should fail as well, @bors r-

Centril · 2019-11-06T06:13:57Z

I always forget this... @bors retry

rust-highfive · 2019-11-06T07:49:03Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-06T05:19:30.8357446Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-06T05:19:30.8592715Z ##[command]git config gc.auto 0
2019-11-06T05:19:30.8657742Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-06T05:19:30.8704212Z ##[command]git config --get-all http.proxy
2019-11-06T05:19:30.8890042Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66142/merge:refs/remotes/pull/66142/merge
---
2019-11-06T06:57:09.8790151Z     Finished release [optimized] target(s) in 10m 33s
2019-11-06T06:59:02.8670425Z Error: there are broken links
2019-11-06T06:59:02.8671332Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html" returned 404 Not Found
2019-11-06T06:59:02.8672064Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html#method.buffer_lint" returned 404 Not Found
2019-11-06T06:59:02.8672681Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-11-06T06:59:02.8673395Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-11-06T06:59:02.8673720Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-11-06T06:59:02.8674058Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-11-06T06:59:02.8674372Z  Caused By: "https://github.com/rust-lang/chalk/blob/master/src/test/wf.rs" returned 404 Not Found
---
2019-11-06T07:13:13.5237603Z 
2019-11-06T07:13:13.5237843Z ------------------------------------------
2019-11-06T07:13:13.5237890Z stderr:
2019-11-06T07:13:13.5238104Z ------------------------------------------
2019-11-06T07:13:13.5239402Z {"message":"can't find crate for `clippy_lints`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/lint_without_lint_pass.rs","byte_start":142,"byte_end":168,"line_start":9,"line_end":9,"column_start":1,"column_end":27,"is_primary":true,"text":[{"text":"extern crate clippy_lints;","highlight_start":1,"highlight_end":27}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `clippy_lints`\n  --> tests/ui/lint_without_lint_pass.rs:9:1\n   |\nLL | extern crate clippy_lints;\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
2019-11-06T07:13:13.5239991Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T07:13:13.5240065Z 
2019-11-06T07:13:13.5240285Z ------------------------------------------
2019-11-06T07:13:13.5240318Z 
---
2019-11-06T07:13:13.5242036Z expected stderr:
2019-11-06T07:13:13.5242099Z error: trivial regex
2019-11-06T07:13:13.5242341Z   --> $DIR/regex.rs:13:45
2019-11-06T07:13:13.5242385Z    |
2019-11-06T07:13:13.5242429Z LL |     let pipe_in_wrong_position = Regex::new("|");
2019-11-06T07:13:13.5242535Z    |
2019-11-06T07:13:13.5242770Z    = note: `-D clippy::trivial-regex` implied by `-D warnings`
2019-11-06T07:13:13.5242837Z    = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5242869Z 
2019-11-06T07:13:13.5242869Z 
2019-11-06T07:13:13.5242909Z error: trivial regex
2019-11-06T07:13:13.5243108Z   --> $DIR/regex.rs:14:60
2019-11-06T07:13:13.5243166Z    |
2019-11-06T07:13:13.5243211Z LL |     let pipe_in_wrong_position_builder = RegexBuilder::new("|");
2019-11-06T07:13:13.5243319Z    |
2019-11-06T07:13:13.5243372Z    = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5243410Z 
2019-11-06T07:13:13.5243410Z 
2019-11-06T07:13:13.5243457Z error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T07:13:13.5243727Z    |
2019-11-06T07:13:13.5243727Z    |
2019-11-06T07:13:13.5243949Z LL |     let wrong_char_ranice = Regex::new("[z-a]");
2019-11-06T07:13:13.5244057Z    |
2019-11-06T07:13:13.5244057Z    |
2019-11-06T07:13:13.5244290Z    = note: `-D clippy::invalid-regex` implied by `-D warnings`
2019-11-06T07:13:13.5244323Z 
2019-11-06T07:13:13.5244386Z error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T07:13:13.5244633Z    |
2019-11-06T07:13:13.5244633Z    |
2019-11-06T07:13:13.5244873Z LL |     let some_unicode = Regex::new("[é-è]");
2019-11-06T07:13:13.5244952Z 
2019-11-06T07:13:13.5245022Z error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5245235Z   --> $DIR/regex.rs:18:33
2019-11-06T07:13:13.5245278Z    |
2019-11-06T07:13:13.5245278Z    |
2019-11-06T07:13:13.5245322Z LL |     let some_regex = Regex::new(OPENING_PAREN);
2019-11-06T07:13:13.5245417Z 
2019-11-06T07:13:13.5245457Z error: trivial regex
2019-11-06T07:13:13.5245661Z   --> $DIR/regex.rs:20:53
2019-11-06T07:13:13.5245720Z    |
2019-11-06T07:13:13.5245720Z    |
2019-11-06T07:13:13.5245763Z LL |     let binary_pipe_in_wrong_position = BRegex::new("|");
2019-11-06T07:13:13.5245868Z    |
2019-11-06T07:13:13.5245911Z    = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5245941Z 
2019-11-06T07:13:13.5245999Z error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5245999Z error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5246204Z   --> $DIR/regex.rs:21:41
2019-11-06T07:13:13.5246246Z    |
2019-11-06T07:13:13.5246298Z LL |     let some_binary_regex = BRegex::new(OPENING_PAREN);
2019-11-06T07:13:13.5246400Z 
2019-11-06T07:13:13.5246445Z error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5246952Z   --> $DIR/regex.rs:22:56
2019-11-06T07:13:13.5247008Z    |
2019-11-06T07:13:13.5247008Z    |
2019-11-06T07:13:13.5247055Z LL |     let some_binary_regex_builder = BRegexBuilder::new(OPENING_PAREN);
2019-11-06T07:13:13.5247156Z 
2019-11-06T07:13:13.5247199Z error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5247412Z   --> $DIR/regex.rs:34:37
2019-11-06T07:13:13.5247470Z    |
2019-11-06T07:13:13.5247470Z    |
2019-11-06T07:13:13.5247725Z LL |     let set_error = RegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T07:13:13.5247805Z 
2019-11-06T07:13:13.5248001Z error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5248310Z   --> $DIR/regex.rs:35:39
2019-11-06T07:13:13.5248359Z    |
2019-11-06T07:13:13.5248359Z    |
2019-11-06T07:13:13.5248650Z LL |     let bset_error = BRegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T07:13:13.5248735Z 
2019-11-06T07:13:13.5248778Z error: regex syntax error: unrecognized escape sequence
2019-11-06T07:13:13.5248999Z   --> $DIR/regex.rs:37:45
2019-11-06T07:13:13.5249041Z    |
2019-11-06T07:13:13.5249041Z    |
2019-11-06T07:13:13.5249084Z LL |     let raw_string_error = Regex::new(r"[...//...]");
2019-11-06T07:13:13.5249177Z 
2019-11-06T07:13:13.5249220Z error: regex syntax error: unrecognized escape sequence
2019-11-06T07:13:13.5249424Z   --> $DIR/regex.rs:38:46
2019-11-06T07:13:13.5249483Z    |
2019-11-06T07:13:13.5249483Z    |
2019-11-06T07:13:13.5249527Z LL |     let raw_string_error = Regex::new(r#"[...//...]"#);
2019-11-06T07:13:13.5249636Z 
2019-11-06T07:13:13.5249676Z error: trivial regex
2019-11-06T07:13:13.5249878Z   --> $DIR/regex.rs:42:33
2019-11-06T07:13:13.5249920Z    |
2019-11-06T07:13:13.5249920Z    |
2019-11-06T07:13:13.5249979Z LL |     let trivial_eq = Regex::new("^foobar$");
2019-11-06T07:13:13.5250066Z    |
2019-11-06T07:13:13.5250066Z    |
2019-11-06T07:13:13.5250123Z    = help: consider using `==` on `str`s
2019-11-06T07:13:13.5250191Z error: trivial regex
2019-11-06T07:13:13.5250393Z   --> $DIR/regex.rs:44:48
2019-11-06T07:13:13.5250450Z    |
2019-11-06T07:13:13.5250450Z    |
2019-11-06T07:13:13.5250495Z LL |     let trivial_eq_builder = RegexBuilder::new("^foobar$");
2019-11-06T07:13:13.5250603Z    |
2019-11-06T07:13:13.5250603Z    |
2019-11-06T07:13:13.5250645Z    = help: consider using `==` on `str`s
2019-11-06T07:13:13.5250711Z error: trivial regex
2019-11-06T07:13:13.5250940Z   --> $DIR/regex.rs:46:42
2019-11-06T07:13:13.5250990Z    |
2019-11-06T07:13:13.5250990Z    |
2019-11-06T07:13:13.5251033Z LL |     let trivial_starts_with = Regex::new("^foobar");
2019-11-06T07:13:13.5251147Z    |
2019-11-06T07:13:13.5251189Z    = help: consider using `str::starts_with`
2019-11-06T07:13:13.5251219Z 
2019-11-06T07:13:13.5251274Z error: trivial regex
2019-11-06T07:13:13.5251274Z error: trivial regex
2019-11-06T07:13:13.5251482Z   --> $DIR/regex.rs:48:40
2019-11-06T07:13:13.5251523Z    |
2019-11-06T07:13:13.5251582Z LL |     let trivial_ends_with = Regex::new("foobar$");
2019-11-06T07:13:13.5251714Z    |
2019-11-06T07:13:13.5251772Z    = help: consider using `str::ends_with`
2019-11-06T07:13:13.5251801Z 
2019-11-06T07:13:13.5251839Z error: trivial regex
---
2019-11-06T07:13:13.5252347Z 
2019-11-06T07:13:13.5252386Z error: trivial regex
2019-11-06T07:13:13.5252607Z   --> $DIR/regex.rs:52:39
2019-11-06T07:13:13.5252651Z    |
2019-11-06T07:13:13.5252696Z LL |     let trivial_contains = Regex::new(NOT_A_REAL_REGEX);
2019-11-06T07:13:13.5252804Z    |
2019-11-06T07:13:13.5252846Z    = help: consider using `str::contains`
2019-11-06T07:13:13.5252875Z 
2019-11-06T07:13:13.5252930Z error: trivial regex
2019-11-06T07:13:13.5252930Z error: trivial regex
2019-11-06T07:13:13.5253132Z   --> $DIR/regex.rs:54:40
2019-11-06T07:13:13.5253173Z    |
2019-11-06T07:13:13.5253216Z LL |     let trivial_backslash = Regex::new("a/.b");
2019-11-06T07:13:13.5253413Z    |
2019-11-06T07:13:13.5253505Z    = help: consider using `str::contains`
2019-11-06T07:13:13.5253555Z 
2019-11-06T07:13:13.5253595Z error: trivial regex
---
2019-11-06T07:13:13.5254104Z 
2019-11-06T07:13:13.5254143Z error: trivial regex
2019-11-06T07:13:13.5254347Z   --> $DIR/regex.rs:59:36
2019-11-06T07:13:13.5254408Z    |
2019-11-06T07:13:13.5254450Z LL |     let trivial_empty = Regex::new("^");
2019-11-06T07:13:13.5254553Z    |
2019-11-06T07:13:13.5254598Z    = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5254628Z 
2019-11-06T07:13:13.5254675Z error: trivial regex
2019-11-06T07:13:13.5254675Z error: trivial regex
2019-11-06T07:13:13.5254895Z   --> $DIR/regex.rs:61:36
2019-11-06T07:13:13.5254946Z    |
2019-11-06T07:13:13.5254988Z LL |     let trivial_empty = Regex::new("^$");
2019-11-06T07:13:13.5255091Z    |
2019-11-06T07:13:13.5255133Z    = help: consider using `str::is_empty`
2019-11-06T07:13:13.5255161Z 
2019-11-06T07:13:13.5255216Z error: trivial regex
2019-11-06T07:13:13.5255216Z error: trivial regex
2019-11-06T07:13:13.5255419Z   --> $DIR/regex.rs:63:44
2019-11-06T07:13:13.5255462Z    |
2019-11-06T07:13:13.5255521Z LL |     let binary_trivial_empty = BRegex::new("^$");
2019-11-06T07:13:13.5255609Z    |
2019-11-06T07:13:13.5255650Z    = help: consider using `str::is_empty`
2019-11-06T07:13:13.5255695Z 
2019-11-06T07:13:13.5255736Z error: aborting due to 23 previous errors
---
2019-11-06T07:13:13.5256332Z -  --> $DIR/regex.rs:13:45
2019-11-06T07:13:13.5256554Z +error[E0463]: can't find crate for `regex`
2019-11-06T07:13:13.5257027Z +  --> $DIR/regex.rs:4:1
2019-11-06T07:13:13.5257073Z     |
2019-11-06T07:13:13.5257322Z -LL |     let pipe_in_wrong_position = Regex::new("|");
2019-11-06T07:13:13.5257729Z -   |
2019-11-06T07:13:13.5257977Z -   = note: `-D clippy::trivial-regex` implied by `-D warnings`
2019-11-06T07:13:13.5258210Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5258257Z +LL | extern crate regex;
2019-11-06T07:13:13.5258257Z +LL | extern crate regex;
2019-11-06T07:13:13.5258484Z +   | ^^^^^^^^^^^^^^^^^^^ can't find crate
2019-11-06T07:13:13.5258528Z  
2019-11-06T07:13:13.5258722Z -error: trivial regex
2019-11-06T07:13:13.5258921Z -  --> $DIR/regex.rs:14:60
2019-11-06T07:13:13.5259119Z -   |
2019-11-06T07:13:13.5259372Z -LL |     let pipe_in_wrong_position_builder = RegexBuilder::new("|");
2019-11-06T07:13:13.5259823Z -   |
2019-11-06T07:13:13.5260047Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5260094Z +error: aborting due to previous error
2019-11-06T07:13:13.5260151Z  
2019-11-06T07:13:13.5260151Z  
2019-11-06T07:13:13.5260408Z -error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T07:13:13.5260818Z -   |
2019-11-06T07:13:13.5260818Z -   |
2019-11-06T07:13:13.5261044Z -LL |     let wrong_char_ranice = Regex::new("[z-a]");
2019-11-06T07:13:13.5261458Z -   |
2019-11-06T07:13:13.5261458Z -   |
2019-11-06T07:13:13.5261693Z -   = note: `-D clippy::invalid-regex` implied by `-D warnings`
2019-11-06T07:13:13.5261869Z -
2019-11-06T07:13:13.5262119Z -error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T07:13:13.5262740Z -   |
2019-11-06T07:13:13.5262740Z -   |
2019-11-06T07:13:13.5262992Z -LL |     let some_unicode = Regex::new("[é-è]");
2019-11-06T07:13:13.5263406Z -
2019-11-06T07:13:13.5263629Z -error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5263845Z -  --> $DIR/regex.rs:18:33
2019-11-06T07:13:13.5264025Z -   |
2019-11-06T07:13:13.5264025Z -   |
2019-11-06T07:13:13.5264243Z -LL |     let some_regex = Regex::new(OPENING_PAREN);
2019-11-06T07:13:13.5264658Z -
2019-11-06T07:13:13.5264846Z -error: trivial regex
2019-11-06T07:13:13.5265043Z -  --> $DIR/regex.rs:20:53
2019-11-06T07:13:13.5265240Z -   |
2019-11-06T07:13:13.5265240Z -   |
2019-11-06T07:13:13.5265468Z -LL |     let binary_pipe_in_wrong_position = BRegex::new("|");
2019-11-06T07:13:13.5265908Z -   |
2019-11-06T07:13:13.5266134Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5266317Z -
2019-11-06T07:13:13.5266541Z -error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5266541Z -error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5267031Z -  --> $DIR/regex.rs:21:41
2019-11-06T07:13:13.5267210Z -   |
2019-11-06T07:13:13.5267438Z -LL |     let some_binary_regex = BRegex::new(OPENING_PAREN);
2019-11-06T07:13:13.5267865Z -
2019-11-06T07:13:13.5268087Z -error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5268304Z -  --> $DIR/regex.rs:22:56
2019-11-06T07:13:13.5268485Z -   |
2019-11-06T07:13:13.5268485Z -   |
2019-11-06T07:13:13.5268728Z -LL |     let some_binary_regex_builder = BRegexBuilder::new(OPENING_PAREN);
2019-11-06T07:13:13.5269170Z -
2019-11-06T07:13:13.5269391Z -error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5269602Z -  --> $DIR/regex.rs:34:37
2019-11-06T07:13:13.5269802Z -   |
2019-11-06T07:13:13.5269802Z -   |
2019-11-06T07:13:13.5270059Z -LL |     let set_error = RegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T07:13:13.5270482Z -
2019-11-06T07:13:13.5270706Z -error: regex syntax error on position 0: unclosed group
2019-11-06T07:13:13.5270906Z -  --> $DIR/regex.rs:35:39
2019-11-06T07:13:13.5271098Z -   |
2019-11-06T07:13:13.5271098Z -   |
2019-11-06T07:13:13.5271352Z -LL |     let bset_error = BRegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T07:13:13.5271771Z -
2019-11-06T07:13:13.5271996Z -error: regex syntax error: unrecognized escape sequence
2019-11-06T07:13:13.5272194Z -  --> $DIR/regex.rs:37:45
2019-11-06T07:13:13.5272370Z -   |
2019-11-06T07:13:13.5272370Z -   |
2019-11-06T07:13:13.5272616Z -LL |     let raw_string_error = Regex::new(r"[...//...]");
2019-11-06T07:13:13.5273022Z -
2019-11-06T07:13:13.5273274Z -error: regex syntax error: unrecognized escape sequence
2019-11-06T07:13:13.5273476Z -  --> $DIR/regex.rs:38:46
2019-11-06T07:13:13.5273651Z -   |
2019-11-06T07:13:13.5273651Z -   |
2019-11-06T07:13:13.5273895Z -LL |     let raw_string_error = Regex::new(r#"[...//...]"#);
2019-11-06T07:13:13.5274299Z -
2019-11-06T07:13:13.5274487Z -error: trivial regex
2019-11-06T07:13:13.5274706Z -  --> $DIR/regex.rs:42:33
2019-11-06T07:13:13.5274883Z -   |
2019-11-06T07:13:13.5274883Z -   |
2019-11-06T07:13:13.5275099Z -LL |     let trivial_eq = Regex::new("^foobar$");
2019-11-06T07:13:13.5275514Z -   |
2019-11-06T07:13:13.5275514Z -   |
2019-11-06T07:13:13.5275722Z -   = help: consider using `==` on `str`s
2019-11-06T07:13:13.5276105Z -error: trivial regex
2019-11-06T07:13:13.5276303Z -  --> $DIR/regex.rs:44:48
2019-11-06T07:13:13.5277191Z -   |
2019-11-06T07:13:13.5277191Z -   |
2019-11-06T07:13:13.5277547Z -LL |     let trivial_eq_builder = RegexBuilder::new("^foobar$");
2019-11-06T07:13:13.5277996Z -   |
2019-11-06T07:13:13.5277996Z -   |
2019-11-06T07:13:13.5278227Z -   = help: consider using `==` on `str`s
2019-11-06T07:13:13.5278589Z -error: trivial regex
2019-11-06T07:13:13.5278806Z -  --> $DIR/regex.rs:46:42
2019-11-06T07:13:13.5278988Z -   |
2019-11-06T07:13:13.5278988Z -   |
2019-11-06T07:13:13.5279213Z -LL |     let trivial_starts_with = Regex::new("^foobar");
2019-11-06T07:13:13.5279637Z -   |
2019-11-06T07:13:13.5279851Z -   = help: consider using `str::starts_with`
2019-11-06T07:13:13.5280026Z -
2019-11-06T07:13:13.5280237Z -error: trivial regex
2019-11-06T07:13:13.5280237Z -error: trivial regex
2019-11-06T07:13:13.5280434Z -  --> $DIR/regex.rs:48:40
2019-11-06T07:13:13.5280611Z -   |
2019-11-06T07:13:13.5280849Z -LL |     let trivial_ends_with = Regex::new("foobar$");
2019-11-06T07:13:13.5281277Z -   |
2019-11-06T07:13:13.5281489Z -   = help: consider using `str::ends_with`
2019-11-06T07:13:13.5281685Z -
2019-11-06T07:13:13.5281873Z -error: trivial regex
---
2019-11-06T07:13:13.5283293Z -
2019-11-06T07:13:13.5283480Z -error: trivial regex
2019-11-06T07:13:13.5283699Z -  --> $DIR/regex.rs:52:39
2019-11-06T07:13:13.5283876Z -   |
2019-11-06T07:13:13.5284106Z -LL |     let trivial_contains = Regex::new(NOT_A_REAL_REGEX);
2019-11-06T07:13:13.5284547Z -   |
2019-11-06T07:13:13.5284755Z -   = help: consider using `str::contains`
2019-11-06T07:13:13.5284953Z -
2019-11-06T07:13:13.5285148Z -error: trivial regex
2019-11-06T07:13:13.5285148Z -error: trivial regex
2019-11-06T07:13:13.5285345Z -  --> $DIR/regex.rs:54:40
2019-11-06T07:13:13.5285521Z -   |
2019-11-06T07:13:13.5285760Z -LL |     let trivial_backslash = Regex::new("a/.b");
2019-11-06T07:13:13.5286161Z -   |
2019-11-06T07:13:13.5286391Z -   = help: consider using `str::contains`
2019-11-06T07:13:13.5286566Z -
2019-11-06T07:13:13.5287034Z -error: trivial regex
---
2019-11-06T07:13:13.5288468Z -
2019-11-06T07:13:13.5288687Z -error: trivial regex
2019-11-06T07:13:13.5288888Z -  --> $DIR/regex.rs:59:36
2019-11-06T07:13:13.5289074Z -   |
2019-11-06T07:13:13.5289307Z -LL |     let trivial_empty = Regex::new("^");
2019-11-06T07:13:13.5289703Z -   |
2019-11-06T07:13:13.5289927Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T07:13:13.5290123Z -
2019-11-06T07:13:13.5290313Z -error: trivial regex
2019-11-06T07:13:13.5290313Z -error: trivial regex
2019-11-06T07:13:13.5290511Z -  --> $DIR/regex.rs:61:36
2019-11-06T07:13:13.5290706Z -   |
2019-11-06T07:13:13.5290926Z -LL |     let trivial_empty = Regex::new("^$");
2019-11-06T07:13:13.5291339Z -   |
2019-11-06T07:13:13.5291554Z -   = help: consider using `str::is_empty`
2019-11-06T07:13:13.5291729Z -
2019-11-06T07:13:13.5291919Z -error: trivial regex
2019-11-06T07:13:13.5291919Z -error: trivial regex
2019-11-06T07:13:13.5292136Z -  --> $DIR/regex.rs:63:44
2019-11-06T07:13:13.5292315Z -   |
2019-11-06T07:13:13.5292536Z -LL |     let binary_trivial_empty = BRegex::new("^$");
2019-11-06T07:13:13.5293206Z -   |
2019-11-06T07:13:13.5293418Z -   = help: consider using `str::is_empty`
2019-11-06T07:13:13.5293593Z -
2019-11-06T07:13:13.5293826Z -error: aborting due to 23 previous errors
---
2019-11-06T07:13:13.5297151Z 
2019-11-06T07:13:13.5297384Z ------------------------------------------
2019-11-06T07:13:13.5297430Z stderr:
2019-11-06T07:13:13.5297641Z ------------------------------------------
2019-11-06T07:13:13.5298879Z {"message":"can't find crate for `regex`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/regex.rs","byte_start":95,"byte_end":114,"line_start":4,"line_end":4,"column_start":1,"column_end":20,"is_primary":true,"text":[{"text":"extern crate regex;","highlight_start":1,"highlight_end":20}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `regex`\n  --> tests/ui/regex.rs:4:1\n   |\nLL | extern crate regex;\n   | ^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
2019-11-06T07:13:13.5299460Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T07:13:13.5299698Z 
2019-11-06T07:13:13.5299952Z ------------------------------------------
2019-11-06T07:13:13.5299985Z 
2019-11-06T07:13:13.5299985Z 
2019-11-06T07:13:13.5300012Z 
2019-11-06T07:13:13.5300255Z ---- [ui] ui/used_underscore_binding.rs stdout ----
2019-11-06T07:13:13.5300304Z normalized stderr:
2019-11-06T07:13:13.5300528Z error[E0463]: can't find crate for `clippy_lints`
2019-11-06T07:13:13.5300762Z   --> $DIR/used_underscore_binding.rs:12:10
2019-11-06T07:13:13.5300809Z    |
2019-11-06T07:13:13.5300852Z LL |   #[derive(DeriveSomething)]
2019-11-06T07:13:13.5300954Z LL | | struct Baz;
2019-11-06T07:13:13.5300994Z LL | |
2019-11-06T07:13:13.5300994Z LL | |
2019-11-06T07:13:13.5301037Z LL | | macro_rules! test_macro {
2019-11-06T07:13:13.5301133Z LL | |
2019-11-06T07:13:13.5301181Z LL | | /// Tests that we lint if we use a binding with a single leading underscore
2019-11-06T07:13:13.5301410Z    | |_^ can't find crate
2019-11-06T07:13:13.5301452Z 
2019-11-06T07:13:13.5301452Z 
2019-11-06T07:13:13.5301502Z error: aborting due to previous error
2019-11-06T07:13:13.5301531Z 
2019-11-06T07:13:13.5301790Z For more information about this error, try `rustc --explain E0463`.
2019-11-06T07:13:13.5301824Z 
2019-11-06T07:13:13.5301849Z 
2019-11-06T07:13:13.5301890Z expected stderr:
2019-11-06T07:13:13.5301960Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5302235Z    |
2019-11-06T07:13:13.5302235Z    |
2019-11-06T07:13:13.5302291Z LL |     _foo + 1
2019-11-06T07:13:13.5302372Z    |
2019-11-06T07:13:13.5302615Z    = note: `-D clippy::used-underscore-binding` implied by `-D warnings`
2019-11-06T07:13:13.5302665Z 
2019-11-06T07:13:13.5302665Z 
2019-11-06T07:13:13.5302718Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5303027Z    |
2019-11-06T07:13:13.5303070Z LL |     println!("{}", _foo);
2019-11-06T07:13:13.5303112Z    |                    ^^^^
2019-11-06T07:13:13.5303140Z 
2019-11-06T07:13:13.5303140Z 
2019-11-06T07:13:13.5303208Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5303479Z    |
2019-11-06T07:13:13.5303479Z    |
2019-11-06T07:13:13.5303537Z LL |     assert_eq!(_foo, _foo);
2019-11-06T07:13:13.5303607Z 
2019-11-06T07:13:13.5303607Z 
2019-11-06T07:13:13.5303658Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5303947Z    |
2019-11-06T07:13:13.5303947Z    |
2019-11-06T07:13:13.5303988Z LL |     assert_eq!(_foo, _foo);
2019-11-06T07:13:13.5304085Z 
2019-11-06T07:13:13.5304085Z 
2019-11-06T07:13:13.5304146Z error: used binding `_underscore_field` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5304437Z    |
2019-11-06T07:13:13.5304437Z    |
2019-11-06T07:13:13.5304479Z LL |     s._underscore_field += 1;
2019-11-06T07:13:13.5304565Z 
2019-11-06T07:13:13.5304608Z error: aborting due to 5 previous errors
2019-11-06T07:13:13.5304636Z 
2019-11-06T07:13:13.5304662Z 
2019-11-06T07:13:13.5304662Z 
2019-11-06T07:13:13.5304703Z 
2019-11-06T07:13:13.5304743Z diff of stderr:
2019-11-06T07:13:13.5304770Z 
2019-11-06T07:13:13.5305067Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5305534Z +error[E0463]: can't find crate for `clippy_lints`
2019-11-06T07:13:13.5305865Z +  --> $DIR/used_underscore_binding.rs:12:10
2019-11-06T07:13:13.5305996Z     |
2019-11-06T07:13:13.5305996Z     |
2019-11-06T07:13:13.5306218Z -LL |     _foo + 1
2019-11-06T07:13:13.5306817Z -   |
2019-11-06T07:13:13.5307133Z -   = note: `-D clippy::used-underscore-binding` implied by `-D warnings`
2019-11-06T07:13:13.5307133Z -   = note: `-D clippy::used-underscore-binding` implied by `-D warnings`
2019-11-06T07:13:13.5307184Z +LL |   #[derive(DeriveSomething)]
2019-11-06T07:13:13.5307286Z +LL | | struct Baz;
2019-11-06T07:13:13.5307328Z +LL | |
2019-11-06T07:13:13.5307328Z +LL | |
2019-11-06T07:13:13.5307370Z +LL | | macro_rules! test_macro {
2019-11-06T07:13:13.5307427Z +...  |
2019-11-06T07:13:13.5307513Z +LL | | /// Tests that we lint if we use a binding with a single leading underscore
2019-11-06T07:13:13.5307725Z +   | |_^ can't find crate
2019-11-06T07:13:13.5307784Z  
2019-11-06T07:13:13.5307784Z  
2019-11-06T07:13:13.5308075Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5308524Z -   |
2019-11-06T07:13:13.5308729Z -LL |     println!("{}", _foo);
2019-11-06T07:13:13.5308931Z -   |                    ^^^^
2019-11-06T07:13:13.5308994Z +error: aborting due to previous error
2019-11-06T07:13:13.5308994Z +error: aborting due to previous error
2019-11-06T07:13:13.5309035Z  
2019-11-06T07:13:13.5309327Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5309750Z -   |
2019-11-06T07:13:13.5309750Z -   |
2019-11-06T07:13:13.5309953Z -LL |     assert_eq!(_foo, _foo);
2019-11-06T07:13:13.5310343Z -
2019-11-06T07:13:13.5310343Z -
2019-11-06T07:13:13.5310630Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5311051Z -   |
2019-11-06T07:13:13.5311051Z -   |
2019-11-06T07:13:13.5311266Z -LL |     assert_eq!(_foo, _foo);
2019-11-06T07:13:13.5311667Z -
2019-11-06T07:13:13.5311667Z -
2019-11-06T07:13:13.5311975Z -error: used binding `_underscore_field` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T07:13:13.5312396Z -   |
2019-11-06T07:13:13.5312396Z -   |
2019-11-06T07:13:13.5312606Z -LL |     s._underscore_field += 1;
2019-11-06T07:13:13.5312979Z -
2019-11-06T07:13:13.5313209Z -error: aborting due to 5 previous errors
2019-11-06T07:13:13.5313384Z -
2019-11-06T07:13:13.5313623Z +For more information about this error, try `rustc --explain E0463`.
---
2019-11-06T07:13:13.5317330Z 
2019-11-06T07:13:13.5317939Z ------------------------------------------
2019-11-06T07:13:13.5317998Z stderr:
2019-11-06T07:13:13.5318221Z ------------------------------------------
2019-11-06T07:13:13.5321092Z {"message":"can't find crate for `clippy_lints`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/used_underscore_binding.rs","byte_start":340,"byte_end":7513112,"line_start":12,"line_end":22,"column_start":10,"column_end":2,"is_primary":true,"text":[],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"tests/ui/used_underscore_binding.rs","byte_start":340,"byte_end":355,"line_start":12,"line_end":12,"column_start":10,"column_end":25,"is_primary":false,"text":[{"text":"#[derive(DeriveSomething)]","highlight_start":10,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"#[derive(DeriveSomething)]","def_site_span":{"file_name":"/checkout/src/tools/clippy/tests/ui/auxiliary/proc_macro_derive.rs","byte_start":215,"byte_end":549,"line_start":11,"line_end":22,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"error[E0463]: can't find crate for `clippy_lints`\n  --> tests/ui/used_underscore_binding.rs:12:10\n   |\nLL |   #[derive(DeriveSomething)]\n   |  __________^\nLL | | struct Baz;\nLL | |\nLL | | macro_rules! test_macro {\n...  |\nLL | |\nLL | | /// Tests that we lint if we use a binding with a single leading underscore\n   | |_^ can't find crate\n\n"}
2019-11-06T07:13:13.5322076Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T07:13:13.5322129Z 
2019-11-06T07:13:13.5322362Z ------------------------------------------
2019-11-06T07:13:13.5322535Z 
---
2019-11-06T07:13:13.5324246Z expected stderr:
2019-11-06T07:13:13.5324288Z error: useless lint attribute
2019-11-06T07:13:13.5324502Z   --> $DIR/useless_attribute.rs:6:1
2019-11-06T07:13:13.5324562Z    |
2019-11-06T07:13:13.5324603Z LL | #[allow(dead_code)]
2019-11-06T07:13:13.5324671Z    | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
2019-11-06T07:13:13.5324973Z    = note: `-D clippy::useless-attribute` implied by `-D warnings`
2019-11-06T07:13:13.5325007Z 
2019-11-06T07:13:13.5325047Z error: useless lint attribute
2019-11-06T07:13:13.5325275Z   --> $DIR/useless_attribute.rs:7:1
2019-11-06T07:13:13.5325275Z   --> $DIR/useless_attribute.rs:7:1
2019-11-06T07:13:13.5325320Z    |
2019-11-06T07:13:13.5325548Z LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
2019-11-06T07:13:13.5325884Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
2019-11-06T07:13:13.5325971Z error: aborting due to 2 previous errors
2019-11-06T07:13:13.5325999Z 
2019-11-06T07:13:13.5326041Z 
2019-11-06T07:13:13.5326067Z 
2019-11-06T07:13:13.5326067Z 
2019-11-06T07:13:13.5326106Z diff of stderr:
2019-11-06T07:13:13.5326133Z 
2019-11-06T07:13:13.5326355Z -error: useless lint attribute
2019-11-06T07:13:13.5326843Z -  --> $DIR/useless_attribute.rs:6:1
2019-11-06T07:13:13.5327132Z +error[E0463]: can't find crate for `clippy_lints`
2019-11-06T07:13:13.5327349Z +  --> $DIR/useless_attribute.rs:14:1
2019-11-06T07:13:13.5327415Z     |
2019-11-06T07:13:13.5327614Z -LL | #[allow(dead_code)]
2019-11-06T07:13:13.5327870Z -   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
2019-11-06T07:13:13.5328308Z -   = note: `-D clippy::useless-attribute` implied by `-D warnings`
2019-11-06T07:13:13.5328357Z +LL | extern crate clippy_lints;
2019-11-06T07:13:13.5328595Z +   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
2019-11-06T07:13:13.5328640Z  
2019-11-06T07:13:13.5328640Z  
2019-11-06T07:13:13.5328842Z -error: useless lint attribute
2019-11-06T07:13:13.5329067Z -  --> $DIR/useless_attribute.rs:7:1
2019-11-06T07:13:13.5329249Z -   |
2019-11-06T07:13:13.5329479Z -LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
2019-11-06T07:13:13.5329814Z -   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
2019-11-06T07:13:13.5329931Z  
2019-11-06T07:13:13.5330146Z -error: aborting due to 2 previous errors
2019-11-06T07:13:13.5330341Z -
2019-11-06T07:13:13.5330578Z +For more information about this error, try `rustc --explain E0463`.
---
2019-11-06T07:13:13.5333464Z 
2019-11-06T07:13:13.5333675Z ------------------------------------------
2019-11-06T07:13:13.5333738Z stderr:
2019-11-06T07:13:13.5333949Z ------------------------------------------
2019-11-06T07:13:13.5335219Z {"message":"can't find crate for `clippy_lints`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":327,"byte_end":353,"line_start":14,"line_end":14,"column_start":1,"column_end":27,"is_primary":true,"text":[{"text":"extern crate clippy_lints;","highlight_start":1,"highlight_end":27}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `clippy_lints`\n  --> tests/ui/useless_attribute.rs:14:1\n   |\nLL | extern crate clippy_lints;\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
2019-11-06T07:13:13.5335825Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T07:13:13.5335880Z 
2019-11-06T07:13:13.5336112Z ------------------------------------------
2019-11-06T07:13:13.5336145Z 
---
2019-11-06T07:48:57.5582521Z Verifying status of rustfmt...
2019-11-06T07:48:57.5594325Z Verifying status of clippy-driver...
2019-11-06T07:48:57.5606411Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-11-06T07:48:57.5617449Z 
2019-11-06T07:48:57.5618448Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-11-06T07:48:57.5618554Z 
2019-11-06T07:48:57.5618892Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-11-06T07:48:57.5618977Z commit another update.
2019-11-06T07:48:57.5619007Z 
2019-11-06T07:48:57.5619270Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-11-06T07:48:57.5619552Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-11-06T07:48:57.5619628Z proper steps.
2019-11-06T07:48:57.5640706Z   local time: Wed Nov  6 07:48:57 UTC 2019
2019-11-06T07:48:57.7224434Z   network time: Wed, 06 Nov 2019 07:48:57 GMT
2019-11-06T07:48:57.7224762Z == end clock drift check ==
2019-11-06T07:48:58.2803356Z 
2019-11-06T07:48:58.2803356Z 
2019-11-06T07:48:58.2921997Z ##[error]Bash exited with code '3'.
2019-11-06T07:48:58.2958125Z ##[section]Starting: Checkout
2019-11-06T07:48:58.2960021Z ==============================================================================
2019-11-06T07:48:58.2960084Z Task         : Get sources
2019-11-06T07:48:58.2960155Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

msizanoen1 · 2019-11-06T09:43:27Z

Build is completely failing, the issue should be fixed when somebody update clippy to master again.
#66150

Update clippy

1b07d95

rust-highfive assigned Manishearth Nov 6, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019

msizanoen1 mentioned this pull request Nov 6, 2019

Prevent building the clippy plugin in rustbuild #66052

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 6, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2019

msizanoen1 closed this Nov 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update clippy#66142

Update clippy#66142
msizanoen1 wants to merge 1 commit intorust-lang:masterfrom
msizanoen1:update-clippy

msizanoen1 commented Nov 6, 2019

Uh oh!

rust-highfive commented Nov 6, 2019

Uh oh!

Manishearth commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

Centril commented Nov 6, 2019

Uh oh!

Centril commented Nov 6, 2019

Uh oh!

rust-highfive commented Nov 6, 2019

Uh oh!

msizanoen1 commented Nov 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

msizanoen1 commented Nov 6, 2019

Uh oh!

rust-highfive commented Nov 6, 2019

Uh oh!

Manishearth commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

Centril commented Nov 6, 2019

Uh oh!

Centril commented Nov 6, 2019

Uh oh!

rust-highfive commented Nov 6, 2019

Uh oh!

msizanoen1 commented Nov 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants