[DO NOT MERGE] deny array_into_iter by default (for crater run)#66201
Closed
LukasKalbertodt wants to merge 1 commit intorust-lang:masterfrom
Closed
[DO NOT MERGE] deny array_into_iter by default (for crater run)#66201LukasKalbertodt wants to merge 1 commit intorust-lang:masterfrom
array_into_iter by default (for crater run)#66201LukasKalbertodt wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
|
Ping from Triage: @davidtwco @LukasKalbertodt any updates? |
Contributor
Author
|
From my side this is ready. We just have to decide if a crater run is useful and then someone needs to prepare a list of all crates that we want to test again and start crater. In my top post I list a few questions about crater; if someone can answer them, that would be helpful. |
Member
|
I'm not sure I'm the best person to review this, r? @Centril |
Contributor
|
cc @pietroalbini for the crater questions. |
Member
No. |
Contributor
Author
|
Given that we can't test for specific versions, I will just close this PR now. I doubt testing "roughly the same set of crates" gives us any useful information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #66017 I had the idea of letting crater test all regressions from #65819 with the
array_into_iterlint on deny. That way we would be able to find out if the lint catches all of the regressions. There is certainly code that could break with #65819 but isn't caught by the lint (see this comment), but we don't know if strange code like that exists in the real world at all.However, I assumed that we can tell crater to compile the exact version of all crates as in the previous run. Looking at this comment it seems like we can only pass crate names (without version) to crater? So....
Can we tell crater which versions of crates to build?NoCan we even tell crater something like "never use dependency versions released after date X"?No