Add more tests for fixed ICEs#66407
Merged
bors merged 5 commits intorust-lang:masterfrom Nov 16, 2019
Merged
Conversation
Centril
reviewed
Nov 14, 2019
Contributor
|
r=me rollup with comment ^-- addressed |
9ab3386 to
44174c3
Compare
Centril
reviewed
Nov 14, 2019
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
d5dad42 to
9cdd854
Compare
Member
Author
|
Ugh, applying suggestion inserted a new line for some reason, fixed. |
Contributor
|
👍 @bors r+ |
Collaborator
|
📌 Commit 9cdd854 has been approved by |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 15, 2019
Add more tests for fixed ICEs Closes rust-lang#36122 (fixed in 1.20.0) Closes rust-lang#58094 (fixed in rust-lang#66054) Also, fix mistaken test case, from rust-lang#30904 to rust-lang#30906 (cc @eddyb) r? @Centril
Member
Author
|
Failed in #66432 (comment) |
Contributor
|
You'll need to do |
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
9cdd854 to
614abe4
Compare
Contributor
|
Let's give it another go, @bors r+ |
Collaborator
|
📌 Commit 614abe4 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 15, 2019
Add more tests for fixed ICEs Closes rust-lang#36122 (fixed in 1.20.0) Closes rust-lang#58094 (fixed in rust-lang#66054) Also, fix mistaken test case, from rust-lang#30904 to rust-lang#30906 (cc @eddyb) r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 15, 2019
Add more tests for fixed ICEs Closes rust-lang#36122 (fixed in 1.20.0) Closes rust-lang#58094 (fixed in rust-lang#66054) Also, fix mistaken test case, from rust-lang#30904 to rust-lang#30906 (cc @eddyb) r? @Centril
bors
added a commit
that referenced
this pull request
Nov 16, 2019
Rollup of 5 pull requests Successful merges: - #66350 (protect creation of destructors by a mutex) - #66407 (Add more tests for fixed ICEs) - #66415 (Add --force-run-in-process unstable option to libtest) - #66427 (Move the JSON error emitter to librustc_errors) - #66441 (libpanic_unwind for Miri: make sure we have the SEH lang items when needed) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36122 (fixed in 1.20.0)
Closes #58094 (fixed in #66054)
Also, fix mistaken test case, from #30904 to #30906 (cc @eddyb)
r? @Centril