syntax: Box ast::MacArgs in attributes#66999
Closed
petrochenkov wants to merge 2 commits intorust-lang:masterfrom
Closed
syntax: Box ast::MacArgs in attributes#66999petrochenkov wants to merge 2 commits intorust-lang:masterfrom
ast::MacArgs in attributes#66999petrochenkov wants to merge 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion |
petrochenkov
added
S-waiting-on-perf
Collaborator
bors
added a commit
that referenced
this pull request
Dec 3, 2019
syntax: Box `ast::MacArgs` in attributes This reduces size of doc comments at cost of an allocation / indirection in regular attributes. Fn-like macros already have `MacArgs` boxed.
Collaborator
|
☀️ Try build successful - checks-azure |
Collaborator
|
Queued 737ec5e with parent f577b0e, future comparison URL. |
Contributor
|
r? @Centril r=me with improved perf |
Collaborator
|
Finished benchmarking try commit 737ec5e, comparison URL. |
Contributor
Author
|
Doesn't look like an improvement. |
Contributor
|
Bummer; thanks for following up anyways! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces size of doc comments at cost of an allocation / indirection in regular attributes.
Fn-like macros already have
MacArgsboxed.Follow-up to #66935.