Closed
Conversation
This reverts commit 089229a.
This reverts commit 8f6197f.
This reverts commit 15c30dd.
Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks.
…f-never-type, r=centril Revert stabilization of never type Fixes rust-lang#66757 I decided to keep the separate `never-type-fallback` feature gate, but tried to otherwise revert rust-lang#65355. Seemed pretty clean. ( cc @Centril, author of rust-lang#65355, you may want to check this over briefly )
…drAus VecDeque: drop remaining items on destructor panic Closes rust-lang#67232
…KodrAus LinkedList: drop remaining items when drop panics rust-lang#67235, but for `LinkedList`, which has the same issue. I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
Don't suggest wrong snippet in closure Fixes rust-lang#67190 r? @estebank
…Match-MatchedSeq, r=Centril Remove the `DelimSpan` from `NamedMatch::MatchedSeq`. Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks. r? @Centril
Require `allow_internal_unstable` for stable min_const_fn using unsta… …ble features r? @Centril cc @ecstatic-morse @RalfJung
…ly, r=alexcrichton Remove i686-unknown-dragonfly target DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.
Contributor
Author
|
@bors r+ p=7 rollup=never |
Collaborator
|
📌 Commit 8e6c199 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 8e6c199 with merge 0f41d81a9113a781232f99a9d94fa7562d178c7d... |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
DelimSpanfromNamedMatch::MatchedSeq. #67250 (Remove theDelimSpanfromNamedMatch::MatchedSeq.)allow_internal_unstablefor stable min_const_fn using unsta… #67251 (Requireallow_internal_unstablefor stable min_const_fn using unsta…)Failed merges:
r? @ghost