Rollup of 5 pull requests

[Centril]

Successful merges:

• Const prop should finish propagation into user defined variables #67130 (Const prop should finish propagation into user defined variables)
• Require stable/unstable annotations for the constness of all stable fns with a const modifier #67136 (Require stable/unstable annotations for the constness of all stable fns with a const modifier)
• Remove i686-unknown-dragonfly target #67255 (Remove i686-unknown-dragonfly target)
• Fix signature of __wasilibc_find_relpath #67267 (Fix signature of __wasilibc_find_relpath)
• Fix example code of OpenOptions::open #67282 (Fix example code of OpenOptions::open)

Failed merges:

r? @ghost

[Centril]

@bors r+ p=5 rollup=never

[bors]

📌 Commit 6df8ddc has been approved by Centril

[bors]

⌛ Testing commit 6df8ddc with merge b6ac9015d0c2cd10f2365e2a3509162f64998ca9...

[rust-highfive]

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-14T03:26:29.9806357Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/borrow_check/nll/constraints/struct.OutlivesConstraintSet.html"
2019-12-14T03:26:29.9806442Z 
2019-12-14T03:26:29.9820926Z      ┌── borrow_check/region_inference/constraint_propagation.md:109:1 ───
2019-12-14T03:26:29.9821357Z      │
2019-12-14T03:26:29.9821623Z  109 │ [converted into the form of a graph][graph-fn], where the nodes of the
2019-12-14T03:26:29.9822245Z      │
2019-12-14T03:26:29.9822281Z 
2019-12-14T03:26:29.9822623Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/borrow_check/nll/region_infer/struct.RegionInferenceContext.html"
2019-12-14T03:26:29.9822701Z 
---
2019-12-14T03:36:26.8562217Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":445,"byte_end":455,"line_start":15,"line_end":15,"column_start":6,"column_end":16,"is_primary":true,"text":[{"text":"    &x[..index];","highlight_start":6,"highlight_end":16}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:15:6\n   |\nLL |     &x[..index];\n   |      ^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T03:36:26.8563597Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":462,"byte_end":485,"line_start":16,"line_end":16,"column_start":6,"column_end":29,"is_primary":true,"text":[{"text":"    &x[index_from..index_to];","highlight_start":6,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..m)` or `.get_mut(n..m)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:16:6\n   |\nLL |     &x[index_from..index_to];\n   |      ^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(n..m)` or `.get_mut(n..m)` instead\n\n"}
2019-12-14T03:36:26.8565224Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":492,"byte_end":519,"line_start":17,"line_end":17,"column_start":6,"column_end":33,"is_primary":true,"text":[{"text":"    &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].","highlight_start":6,"highlight_end":33}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:17:6\n   |\nLL |     &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].\n   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T03:36:26.8566766Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":492,"byte_end":507,"line_start":17,"line_end":17,"column_start":6,"column_end":21,"is_primary":true,"text":[{"text":"    &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].","highlight_start":6,"highlight_end":21}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..)` or .get_mut(n..)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:17:6\n   |\nLL |     &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].\n   |      ^^^^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(n..)` or .get_mut(n..)` instead\n\n"}
2019-12-14T03:36:26.8568250Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":767,"byte_end":779,"line_start":20,"line_end":20,"column_start":6,"column_end":18,"is_primary":true,"text":[{"text":"    &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].","highlight_start":6,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:20:6\n   |\nLL |     &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].\n   |      ^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T03:36:26.8569829Z {"message":"range is out of bounds","code":{"code":"clippy::out_of_bounds_indexing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":769,"byte_end":770,"line_start":20,"line_end":20,"column_start":8,"column_end":9,"is_primary":true,"text":[{"text":"    &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].","highlight_start":8,"highlight_end":9}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::out-of-bounds-indexing` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: range is out of bounds\n  --> tests/ui/indexing_slicing.rs:20:8\n   |\nLL |     &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].\n   |        ^\n   |\n   = note: `-D clippy::out-of-bounds-indexing` implied by `-D warnings`\n\n"}
2019-12-14T03:36:26.8572619Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":885,"byte_end":896,"line_start":22,"line_end":22,"column_start":6,"column_end":17,"is_primary":true,"text":[{"text":"    &x[1..][..5];","highlight_start":6,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:22:6\n   |\nLL |     &x[1..][..5];\n   |      ^^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T03:36:26.8573852Z {"message":"indexing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":1112,"byte_end":1116,"line_start":30,"line_end":30,"column_start":5,"column_end":9,"is_primary":true,"text":[{"text":"    y[0];","highlight_start":5,"highlight_end":9}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n)` or `.get_mut(n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: indexing may panic.\n  --> tests/ui/indexing_slicing.rs:30:5\n   |\nLL |     y[0];\n   |     ^^^^\n   |\n   = help: Consider using `.get(n)` or `.get_mut(n)` instead\n\n"}
2019-12-14T03:36:26.8575230Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":1123,"byte_end":1130,"line_start":31,"line_end":31,"column_start":6,"column_end":13,"is_primary":true,"text":[{"text":"    &y[1..2];","highlight_start":6,"highlight_end":13}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..m)` or `.get_mut(n..m)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:31:6\n   |\nLL |     &y[1..2];\n   |      ^^^^^^^\n   |\n   = help: Consider using `.get(n..m)` or `.get_mut(n..m)` instead\n\n"}
2019-12-14T03:36:26.8576540Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":1137,"byte_end":1145,"line_start":32,"line_end":32,"column_start":6,"column_end":14,"is_primary":true,"text":[{"text":"    &y[0..=4];","highlight_start":6,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..m)` or `.get_mut(n..m)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:32:6\n   |\nLL |     &y[0..=4];\n   |      ^^^^^^^^\n   |\n   = help: Consider using `.get(n..m)` or `.get_mut(n..m)` instead\n\n"}
---
2019-12-14T04:06:49.6855070Z Verifying status of clippy-driver...
2019-12-14T04:06:49.6855127Z Verifying status of miri...
2019-12-14T04:06:49.6855335Z Verifying status of embedded-book...
2019-12-14T04:06:49.6855593Z Verifying status of rustc-guide...
2019-12-14T04:06:49.6865066Z error: Tool `clippy-driver` should be test-pass but is test-fail during beta week.
2019-12-14T04:06:49.6872349Z Build completed unsuccessfully in 0:00:00
2019-12-14T04:06:49.6910983Z == clock drift check ==
2019-12-14T04:06:49.6920843Z   local time: Sat Dec 14 04:06:49 UTC 2019
2019-12-14T04:06:49.9583284Z   network time: Sat, 14 Dec 2019 04:06:49 GMT
2019-12-14T04:06:49.9583284Z   network time: Sat, 14 Dec 2019 04:06:49 GMT
2019-12-14T04:06:49.9586685Z == end clock drift check ==
2019-12-14T04:06:50.4239502Z 
2019-12-14T04:06:50.4315213Z ##[error]Bash exited with code '1'.
2019-12-14T04:06:50.4349631Z ##[section]Starting: Checkout
2019-12-14T04:06:50.4351529Z ==============================================================================
2019-12-14T04:06:50.4351618Z Task         : Get sources
2019-12-14T04:06:50.4351682Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[bors]

💔 Test failed - checks-azure