Merged
Conversation
…em in constant contexts
This purges uses of uninitialized where possible from test cases. Some are merely moved over to the equally bad pattern of MaybeUninit::uninit().assume_init() but with an annotation that this is "the best we can do".
Co-Authored-By: Ralf Jung <post@ralfj.de>
The function is never used inside lowering, but only ever in external crates. By moving it, we faciliate lowering as its own crate.
Add PartialEq and Eq to Cursor closes rust-lang#67226
Require const stability attributes on intrinsics to be able to use them in constant contexts r? @Centril finally fixes rust-lang#61495 cc @RalfJung
…tril Remove mem::uninitalized from tests This purges uses of uninitialized where possible from test cases. Some are merely moved over to the equally bad pattern of MaybeUninit::uninit().assume_init() but with an annotation that this is "the best we can do". Fixes rust-lang#62397
…h, r=kinnison Results show too much Fixes rust-lang#67461. To reproduce the current issue: search anything, then once the results appears, press escape. They should disappear then re-appear right away. This is because blurring an element triggers the "change" event. r? @kinnison
…rk-Simulacrum
Move `{hir::lowering -> hir}::is_range_literal`
The function is never used inside lowering, but only ever in external crates.
By moving it, we facilitate lowering as its own crate.
Best read commit-by-commit.
r? @Mark-Simulacrum
…ntril Improve diagnostics for invalid assignment - Improve wording and span information for invalid assignment diagnostics. - Link to rust-lang/rfcs#372 when it appears the user is trying a destructuring assignment. - Make the equality constraint in `where` clauses error consistent with the invalid assignment error.
Fix ICE in mir interpretation Indices from the end start at 1 so you can immediately subtract them from the length to get the index instead of having to do an additional `-1`. Kinda documented in https://doc.rust-lang.org/nightly/nightly-rustc/rustc/mir/enum.ProjectionElem.html#variant.ConstantIndex
Document that calling Drop, even after it panics, is UB Fixes rust-lang#60822. r? @gnzlbg
Contributor
Author
|
@bors r+ p=8 rollup=never |
Collaborator
|
📌 Commit 68a9a2d has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
the
S-waiting-on-bors
Contributor
Author
|
@bors p=200 |
Collaborator
|
⌛ Testing commit 68a9a2d with merge 89ff48672fe0f19a947f573b9175bdb7add77d6e... |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Dec 23, 2019
Rollup of 8 pull requests Successful merges: - #67233 (Add PartialEq and Eq to Cursor) - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts) - #67507 (Remove mem::uninitalized from tests) - #67527 (Results show too much) - #67536 (Move `{hir::lowering -> hir}::is_range_literal`) - #67538 (Improve diagnostics for invalid assignment) - #67546 (Fix ICE in mir interpretation) - #67559 (Document that calling Drop, even after it panics, is UB) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Dec 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
{hir::lowering -> hir}::is_range_literal#67536 (Move{hir::lowering -> hir}::is_range_literal)Failed merges:
r? @ghost