Merged
Conversation
Reverts part of rust-lang#67676
- Use the span of the predicate - Use the def's description instead of "struct/enum" (notably incorrect for unions) - Align formatting with other error messages
These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway.
Revert `const_err` lint checking of casts Reverts part of rust-lang#67676 r? @oli-obk cc @SimonSapin
…enkov improve some `Drop`-related error messages
…r=Dylan-DPC Clean up err codes r? @Dylan-DPC
…an-DPC Remove unused `#[link_name = "m"]` attributes These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway. They should have triggered a compile error: rust-lang#47725
Member
Author
|
@bors: r+ p=4 |
Collaborator
|
📌 Commit a86a189 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_errlint checking of casts #67822 (Revertconst_errlint checking of casts)Drop-related error messages #67823 (improve someDrop-related error messages)#[link_name = "m"]attributes #67848 (Remove unused#[link_name = "m"]attributes)Failed merges:
r? @ghost