Update rustc-guide by JohnTitor · Pull Request #67940 · rust-lang/rust

JohnTitor · 2020-01-06T15:55:31Z

r? @ghost

CC: @rust-lang/wg-learning

JohnTitor · 2020-01-06T15:56:32Z

This is submodule-only.
@bors r+ rollup=never

bors · 2020-01-06T15:56:33Z

📌 Commit 2aa6457149e87d12e081b6ec6ad35f0dc860305a has been approved by JohnTitor

JohnTitor · 2020-01-08T19:12:15Z

Needs more link fix, out of the queue for now.
@bors r-

rust-highfive · 2020-01-12T13:02:54Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-12T10:50:59.9893631Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-12T10:50:59.9903654Z ##[command]git config gc.auto 0
2020-01-12T10:50:59.9906703Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-12T10:50:59.9908490Z ##[command]git config --get-all http.proxy
2020-01-12T10:50:59.9910800Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67940/merge:refs/remotes/pull/67940/merge
---
2020-01-12T12:36:54.6570712Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/index.html"
2020-01-12T12:36:54.6570890Z 
2020-01-12T12:36:54.6571732Z     ┌── stabilization_guide.md:94:1 ───
2020-01-12T12:36:54.6572072Z     │
2020-01-12T12:36:54.6572642Z  94 │ [`src/libsyntax/feature_gate.rs`]. Search for the `declare_features!`
2020-01-12T12:36:54.6573623Z     │
2020-01-12T12:36:54.6573798Z 
2020-01-12T12:36:54.6573798Z 
2020-01-12T12:36:54.6574460Z error: Unable to retrieve "http://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf": https://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf: error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1915: (unable to get local issuer certificate)
2020-01-12T12:36:54.6575182Z     ┌── appendix/bibliography.md:33:3 ───
2020-01-12T12:36:54.6577970Z     │
2020-01-12T12:36:54.6577970Z     │
2020-01-12T12:36:54.6578597Z  33 │ * [Non-blocking steal-half work queues](http://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf)
2020-01-12T12:36:54.6579348Z     │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ https://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf: error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1915: (unable to get local issuer certificate)
2020-01-12T12:36:54.6579902Z 
2020-01-12T12:36:54.6580045Z Error: One or more incorrect links
2020-01-12T12:36:54.6580230Z 
2020-01-12T12:36:54.6580374Z 
---
2020-01-12T13:02:30.0562483Z 
2020-01-12T13:02:30.0562894Z If you do intend to update 'rustc-guide', please check the error messages above and
2020-01-12T13:02:30.0563091Z commit another update.
2020-01-12T13:02:30.0563219Z 
2020-01-12T13:02:30.0563749Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2020-01-12T13:02:30.0564185Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2020-01-12T13:02:30.0564472Z proper steps.
2020-01-12T13:02:30.0569183Z Build completed unsuccessfully in 0:00:01
2020-01-12T13:02:30.0622212Z == clock drift check ==
2020-01-12T13:02:30.0640878Z   local time: Sun Jan 12 13:02:30 UTC 2020
2020-01-12T13:02:30.2080004Z   network time: Sun, 12 Jan 2020 13:02:30 GMT
2020-01-12T13:02:30.2080004Z   network time: Sun, 12 Jan 2020 13:02:30 GMT
2020-01-12T13:02:30.2080888Z == end clock drift check ==
2020-01-12T13:02:31.4401130Z 
2020-01-12T13:02:31.4524227Z ##[error]Bash exited with code '1'.
2020-01-12T13:02:31.4564493Z ##[section]Starting: Checkout
2020-01-12T13:02:31.4566866Z ==============================================================================
2020-01-12T13:02:31.4566943Z Task         : Get sources
2020-01-12T13:02:31.4566993Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-13T16:32:59Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-13T14:41:11.2016488Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-13T14:41:11.2024338Z ##[command]git config gc.auto 0
2020-01-13T14:41:11.2026002Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-13T14:41:11.2027573Z ##[command]git config --get-all http.proxy
2020-01-13T14:41:11.2029787Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67940/merge:refs/remotes/pull/67940/merge
---
2020-01-13T16:10:02.3290534Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/transform/fn.mir_built.html"
2020-01-13T16:10:02.3293264Z 
2020-01-13T16:10:02.3294104Z     ┌── mir/construction.md:14:42 ───
2020-01-13T16:10:02.3294584Z     │
2020-01-13T16:10:02.3295107Z  14 │ The lowering is triggered by calling the [`mir_built`] query.
2020-01-13T16:10:02.3296505Z     │
2020-01-13T16:10:02.3296768Z 
2020-01-13T16:10:02.3297486Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/hair/index.html"
2020-01-13T16:10:02.3297746Z 
2020-01-13T16:10:02.3297746Z 
2020-01-13T16:10:02.3298807Z     ┌── mir/construction.md:16:36 ───
2020-01-13T16:10:02.3299346Z     │
2020-01-13T16:10:02.3299815Z  16 │ between [HIR] and [MIR] called the [HAIR] that is only used during the lowering.
2020-01-13T16:10:02.3300785Z     │
2020-01-13T16:10:02.3300939Z 
2020-01-13T16:10:02.3301575Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/hair/index.html"
2020-01-13T16:10:02.3301746Z 
---
2020-01-13T16:10:02.3307272Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/hair/index.html"
2020-01-13T16:10:02.3307458Z 
2020-01-13T16:10:02.3307797Z     ┌── mir/construction.md:22:5 ───
2020-01-13T16:10:02.3308117Z     │
2020-01-13T16:10:02.3308535Z  22 │ The [HAIR] has datatypes that mirror the [HIR] datatypes, but instead of e.g. `-x`
2020-01-13T16:10:02.3309643Z     │
2020-01-13T16:10:02.3309807Z 
2020-01-13T16:10:02.3310206Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/hair/index.html"
2020-01-13T16:10:02.3310357Z 
---
2020-01-13T16:10:02.3319152Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/hair/cx/expr/trait.ToBorrowKind.html"
2020-01-13T16:10:02.3319310Z 
2020-01-13T16:10:02.3319650Z     ┌── borrow_check/two_phase_borrows.md:61:36 ───
2020-01-13T16:10:02.3319991Z     │
2020-01-13T16:10:02.3320406Z  61 │ after type checking, which is then [converted] to a [`BorrowKind`] during MIR
2020-01-13T16:10:02.3321132Z     │
2020-01-13T16:10:02.3321279Z 
2020-01-13T16:10:02.3321923Z error: Unable to retrieve "http://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf": https://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf: error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1915: (unable to get local issuer certificate)
2020-01-13T16:10:02.3322103Z 
---
2020-01-13T16:32:52.4950171Z 
2020-01-13T16:32:52.4950823Z If you do intend to update 'rustc-guide', please check the error messages above and
2020-01-13T16:32:52.4951124Z commit another update.
2020-01-13T16:32:52.4951305Z 
2020-01-13T16:32:52.4951727Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2020-01-13T16:32:52.4952294Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2020-01-13T16:32:52.4952559Z proper steps.
2020-01-13T16:32:52.5015274Z   local time: Mon Jan 13 16:32:52 UTC 2020
2020-01-13T16:32:52.5233232Z   network time: Mon, 13 Jan 2020 16:32:52 GMT
2020-01-13T16:32:52.5235447Z == end clock drift check ==
2020-01-13T16:32:53.2778976Z 
2020-01-13T16:32:53.2778976Z 
2020-01-13T16:32:53.2868370Z ##[error]Bash exited with code '1'.
2020-01-13T16:32:53.2905412Z ##[section]Starting: Checkout
2020-01-13T16:32:53.2906878Z ==============================================================================
2020-01-13T16:32:53.2906924Z Task         : Get sources
2020-01-13T16:32:53.2906980Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-14T01:28:25Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-13T23:12:47.6235854Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-13T23:12:47.6251007Z ##[command]git config gc.auto 0
2020-01-13T23:12:47.6255669Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-13T23:12:47.6260435Z ##[command]git config --get-all http.proxy
2020-01-13T23:12:47.6266184Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67940/merge:refs/remotes/pull/67940/merge
---
2020-01-14T01:28:05.1297148Z 
2020-01-14T01:28:05.1297451Z If you do intend to update 'rustc-guide', please check the error messages above and
2020-01-14T01:28:05.1297503Z commit another update.
2020-01-14T01:28:05.1297549Z 
2020-01-14T01:28:05.1297990Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2020-01-14T01:28:05.1298280Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2020-01-14T01:28:05.1298362Z proper steps.
2020-01-14T01:28:05.1308447Z Build completed unsuccessfully in 0:00:01
2020-01-14T01:28:05.1427695Z == clock drift check ==
2020-01-14T01:28:05.1444591Z   local time: Tue Jan 14 01:28:05 UTC 2020
2020-01-14T01:28:05.4336913Z   network time: Tue, 14 Jan 2020 01:28:05 GMT
2020-01-14T01:28:05.4336913Z   network time: Tue, 14 Jan 2020 01:28:05 GMT
2020-01-14T01:28:05.4337403Z == end clock drift check ==
2020-01-14T01:28:06.0328504Z 
2020-01-14T01:28:06.0443841Z ##[error]Bash exited with code '1'.
2020-01-14T01:28:06.0487898Z ##[section]Starting: Checkout
2020-01-14T01:28:06.0489748Z ==============================================================================
2020-01-14T01:28:06.0489828Z Task         : Get sources
2020-01-14T01:28:06.0489883Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JohnTitor · 2020-01-14T09:38:20Z

Okay, it should be fine...
@bors r+

bors · 2020-01-14T09:38:22Z

📌 Commit 6421127 has been approved by JohnTitor

bors · 2020-01-17T19:34:45Z

⌛ Testing commit 6421127 with merge a06f9f1...

@ghost

Update rustc-guide r? @ghost CC: @rust-lang/wg-learning

@ghost

Update rustc-guide r? @ghost CC: @rust-lang/wg-learning

tmandry · 2020-01-17T19:42:02Z

@bors retry rolled up

IMO this shouldn't be rollup=never, since it seems low-risk once it's passing smoke tests.

mark-i-m · 2020-01-17T20:02:36Z

@tmandry We did this in the past, but spurious failures tended to cause rollup failures, so we adopted a policy of not rolling up rustc-guide update.

This is part of the reason why WG-learning makes its own PRs to update the guide, rather than ehuss doing it with their regular round of book/doc updates.

tmandry · 2020-01-17T22:40:03Z

Okay, good to know. Can you elaborate on what kind of spurious failures tend to happen?

JohnTitor · 2020-01-17T22:48:18Z

@tmandry rustc-guide checks links on CI but some links cause spurious failures like not found, temporarily unavailable, etc. See also previous PR: #66161

mark-i-m · 2020-01-17T22:53:51Z

Yes, or some link breaks over night while the PR is in the queue, as happened at the top of this PR.

tmandry · 2020-01-17T23:08:42Z

Got it, thanks.

I know this isn't really the place for this discussion, but it seems reasonable to me to leave the link checks for smoke tests and not put those in CI.

mark-i-m · 2020-01-18T04:19:01Z

Not sure what others think, but I'm open to suggestions. The main thing is that it is helpful for rustc-guide to be tracked by toolstate.

bors · 2020-01-18T04:45:27Z

⌛ Testing commit 6421127 with merge fb4ac14...

@ghost

Update rustc-guide r? @ghost CC: @rust-lang/wg-learning

bors · 2020-01-18T08:06:30Z

☀️ Test successful - checks-azure
Approved by: JohnTitor
Pushing fb4ac14 to master...

rust-highfive · 2020-01-18T08:07:38Z

📣 Toolstate changed by #67940!

Tested on commit fb4ac14.
Direct link to PR: #67940

🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

@JohnTitor

Tested on commit rust-lang/rust@fb4ac14. Direct link to PR: <rust-lang/rust#67940> 🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 6, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2020

JohnTitor force-pushed the rustc-guide branch from 2aa6457 to e65cbc8 Compare January 12, 2020 10:50

JohnTitor force-pushed the rustc-guide branch from e65cbc8 to ab77318 Compare January 13, 2020 14:40

JohnTitor force-pushed the rustc-guide branch from ab77318 to 6e76873 Compare January 13, 2020 23:12

Update rustc-guide

6421127

JohnTitor force-pushed the rustc-guide branch from 6e76873 to 6421127 Compare January 14, 2020 05:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2020

bors added a commit that referenced this pull request Jan 17, 2020

Auto merge of #67940 - JohnTitor:rustc-guide, r=JohnTitor

a06f9f1

Update rustc-guide r? @ghost CC: @rust-lang/wg-learning

tmandry added a commit to tmandry/rust that referenced this pull request Jan 17, 2020

Rollup merge of rust-lang#67940 - JohnTitor:rustc-guide, r=JohnTitor

ce3bfeb

Update rustc-guide r? @ghost CC: @rust-lang/wg-learning

tmandry mentioned this pull request Jan 17, 2020

Rollup of 7 pull requests #68319

Closed

bors added a commit that referenced this pull request Jan 18, 2020

Auto merge of #67940 - JohnTitor:rustc-guide, r=JohnTitor

fb4ac14

Update rustc-guide r? @ghost CC: @rust-lang/wg-learning

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 18, 2020

bors merged commit 6421127 into rust-lang:master Jan 18, 2020

JohnTitor deleted the rustc-guide branch January 18, 2020 08:10

Uh oh!

Conversation

JohnTitor commented Jan 6, 2020

Uh oh!

JohnTitor commented Jan 6, 2020

Uh oh!

bors commented Jan 6, 2020

Uh oh!

JohnTitor commented Jan 8, 2020

Uh oh!

rust-highfive commented Jan 12, 2020

Uh oh!

rust-highfive commented Jan 13, 2020

Uh oh!

rust-highfive commented Jan 14, 2020

Uh oh!

JohnTitor commented Jan 14, 2020

Uh oh!

bors commented Jan 14, 2020

Uh oh!

bors commented Jan 17, 2020

Uh oh!

tmandry commented Jan 17, 2020

Uh oh!

mark-i-m commented Jan 17, 2020

Uh oh!

tmandry commented Jan 17, 2020

Uh oh!

JohnTitor commented Jan 17, 2020

Uh oh!

mark-i-m commented Jan 17, 2020

Uh oh!

tmandry commented Jan 17, 2020

Uh oh!

mark-i-m commented Jan 18, 2020

Uh oh!

bors commented Jan 18, 2020

Uh oh!

bors commented Jan 18, 2020

Uh oh!

rust-highfive commented Jan 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants