Revive delay_span_bug to prevent ICE in const_generics#67974
Closed
JohnTitor wants to merge 1 commit intorust-lang:masterfrom
Closed
Revive delay_span_bug to prevent ICE in const_generics#67974JohnTitor wants to merge 1 commit intorust-lang:masterfrom
JohnTitor wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
We should never be hiding ICEs that require a feature gate enabled. |
Member
Author
Hm, so we should just close this then find another approach, right? |
Contributor
|
I would prefer to have some understanding of what's going wrong here before we make a core part of the type system more fragile. |
Member
Author
|
Got it, then closing this. Thanks for letting me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
delay_span_bugremoved by cd3ead1 in #67160. But it acutually hides bugs so I think we should revive it.Fixes #67883