When an ADT field is missing a stability attribute, look at its parent#68401
Closed
estebank wants to merge 1 commit intorust-lang:masterfrom
Closed
When an ADT field is missing a stability attribute, look at its parent#68401estebank wants to merge 1 commit intorust-lang:masterfrom
estebank wants to merge 1 commit intorust-lang:masterfrom
Conversation
This will allow us to remove stability attributes in fields in the stdlib which are shown in user visible output unnecessarily, obscuring the meaning of the span.
Contributor
|
I'd prefer to avoid adding arbitrary exceptions into the stability system without strong reasons. Standard library is currently shipped with remapped paths and spans from it are not displayed, so this is not a pressing issue. fn main() {
ok;
}
---
error[E0425]: cannot find value `ok` in this scope
--> src/main.rs:2:5
|
2 | ok;
| ^^
|
help: a tuple variant with a similar name exists
|
2 | Ok;
| ^^
help: possible candidates are found in other modules, you can import them into scope
|
1 | use futures::future::ok;
|
1 | use futures_util::future::ok;
| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to remove stability attributes in fields in the stdlib which are shown in user visible output unnecessarily, obscuring the meaning of the span.
Partially address verbosity issues with the new output for #65386 introduced in #65912.
Once this is landed, we can manually modify the stdlib to no longer include
stableattributes in tuple-like fields. This way the output can go from:to
r? @petrochenkov