Merged
Conversation
On the backend, rustdoc now emits `paths` entries to a crate's search index for struct-like enum variants, and index items of type structfield which belong to such variants point to their variant parents in the `paths` table, rather than their enum grandparents. The path entry for a variant is the fully qualified module path plus the enum name. On the frontend, the search code recognizes structfields belonging to structlike variants in the `paths` table and re-constructs the URL to the field's anchor on the enum documentation page. closes rust-lang#16017
Contributor
|
I've built and verified this works against a local trivial test case. For some reason I failed to run the JS tests locally, I must be missing something. |
kinnison
approved these changes
Feb 1, 2020
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
The change looks sane, though as I said I can't verify the test case per-se
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 862af62 has been approved by |
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 1, 2020
…-search, r=kinnison Struct variant field search Fixes rust-lang#16017. Reopening of rust-lang#64724. cc @tomjakubowski cc @ollie27 r? @kinnison
Collaborator
|
⌛ Testing commit 862af62 with merge e7580348ea0e0747a8775b1df6ea22ddd63a9d56... |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…-search, r=kinnison Struct variant field search Fixes rust-lang#16017. Reopening of rust-lang#64724. cc @tomjakubowski cc @ollie27 r? @kinnison
Member
|
@bors retry rolledup |
Collaborator
|
⌛ Testing commit 862af62 with merge 6c85a17e145d1c6fa36a02de58c81c5103ca00ca... |
Member
|
Failed in #68747 (comment) |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
struct-variant-field-search
branch
from
862af62 to
8ee30db
Compare
ollie27
approved these changes
Feb 15, 2020
Contributor
|
This looks good to me. @bors r+ |
Collaborator
|
📌 Commit 8ee30db has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Feb 15, 2020
…ollie27 Struct variant field search Fixes #16017. Reopening of #64724. cc @tomjakubowski cc @ollie27 r? @kinnison
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16017.
Reopening of #64724.
cc @tomjakubowski
cc @ollie27
r? @kinnison