Skip to content

[experiment] proc_macro: Redirect Span::call_site to Span::mixed_site#68766

Closed
petrochenkov wants to merge 1 commit intorust-lang:masterfrom
petrochenkov:mixedcall
Closed

[experiment] proc_macro: Redirect Span::call_site to Span::mixed_site#68766
petrochenkov wants to merge 1 commit intorust-lang:masterfrom
petrochenkov:mixedcall

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 2, 2020 •
edited
Loading

The goal is to approximately check how much disruption will be caused by crates like quote changing the default hygiene to the macro_rules one.

r? @ghost

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Feb 2, 2020

@bors try

@bors
Copy link
Collaborator

bors commented Feb 2, 2020

⌛ Trying commit 2810704 with merge f149601db42efe10ece8b284ab681fd4a6fcb89c...

@petrochenkov petrochenkov added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 2, 2020
@petrochenkov petrochenkov mentioned this pull request Feb 2, 2020
Merged
@bors
Copy link
Collaborator

bors commented Feb 2, 2020

☀️ Try build successful - checks-azure
Build commit: f149601db42efe10ece8b284ab681fd4a6fcb89c (f149601db42efe10ece8b284ab681fd4a6fcb89c)

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Feb 2, 2020

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Feb 2, 2020

👌 Experiment pr-68766 created and queued.
🤖 Automatically detected try build f149601db42efe10ece8b284ab681fd4a6fcb89c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Feb 4, 2020

🚧 Experiment pr-68766 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Feb 7, 2020

🎉 Experiment pr-68766 is completed!
📊 3578 regressed and 0 fixed (88601 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 7, 2020
@dtolnay
Copy link
Member

dtolnay commented Feb 7, 2020

Let's follow up in #68716.

@dtolnay dtolnay closed this Feb 7, 2020
@dtolnay dtolnay self-assigned this Feb 7, 2020
@petrochenkov petrochenkov deleted the mixedcall branch February 22, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petrochenkov @bors @craterbot @dtolnay