Split librustc::{traits,infer} to their respective crates by cjgillot · Pull Request #69076 · rust-lang/rust

cjgillot · 2020-02-11T22:29:28Z

Followup on #67953.

I tried to follow the existing module structures.

bors · 2020-02-12T13:34:54Z

☔ The latest upstream changes (presumably #69088) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2020-02-12T19:46:35Z

☔ The latest upstream changes (presumably #69094) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2020-02-17T10:16:34Z

☔ The latest upstream changes (presumably #69226) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2020-02-17T11:25:52Z

Would rustc_trait_selection be a better crate name for rustc_infer::traits?

cc @rust-lang/compiler

Zoxc · 2020-02-17T18:07:03Z

Could you split Querify object_safety_violations. into a separate PR so we can run perf on it?

@Zoxc

Querify object_safety_violations. Split from #69076 r? @Zoxc

Zoxc · 2020-02-21T20:46:39Z

This seems to be a bit too heavy on trait stuff for me to review.

r? @matthewjasper

matthewjasper · 2020-02-24T21:39:15Z

src/librustc_infer/lib.rs

This was only needed for the parallel compiler. Can you try building it before removing this?

I managed to compile as is.

Looks like this is needed anyway for rustdoc.

bors · 2020-02-26T12:59:20Z

☔ The latest upstream changes (presumably #61812) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2020-02-26T19:17:04Z

ping in #69076 (comment)

[triagebot] Not my area of expertise.

bors · 2020-02-28T05:52:55Z

☔ The latest upstream changes (presumably #69534) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2020-02-28T09:41:45Z

☔ The latest upstream changes (presumably #68505) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2020-02-28T21:22:37Z

☔ The latest upstream changes (presumably #69555) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2020-03-14T19:55:36Z

📣 Toolstate changed by #69076!

Tested on commit 131772c.
Direct link to PR: #69076

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

@mcarton

Tested on commit rust-lang/rust@131772c. Direct link to PR: <rust-lang/rust#69076> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

Rustup to rust-lang/rust#69076 changelog: none

Changes: ```` rustup rust-lang#69738 rustup rust-lang#68944 Make use of `or_patterns` feature rustup rust-lang#69589 Rustup to rust-lang#69076 Don't convert Path to lossy str Use `into_path` Use pattern matching instead of manually checking condition Fix typo Remove git2 dependency. Document that wildcard_imports doesn't warn about `use ...::prelude::*;` Change changelog formatting Update changelog_update doc to reflect the actual ordering of the changelog Update CHANGELOG.md ```` Fixes rust-lang#70007

submodules: update clippy from 8485d40 to d556bb7 Changes: ```` rustup #68944 rustup #69589 Rustup to #69076 Don't convert Path to lossy str Use `into_path` Use pattern matching instead of manually checking condition Fix typo Remove git2 dependency. Document that wildcard_imports doesn't warn about `use ...::prelude::*;` Change changelog formatting Update changelog_update doc to reflect the actual ordering of the changelog Update CHANGELOG.md ```` Fixes #70007

nnethercote · 2020-04-08T04:45:47Z

This change regressed compile time of the keccak benchmark significantly.

@cjgillot: any idea why, and how to fix it?

Zoxc · 2020-04-08T07:14:32Z

@nnethercote It's probably due to things not being inlined anymore. This PR seems to restore performance for keccack.

Changes: ```` rustup rust-lang/rust#69738 rustup rust-lang/rust#68944 Make use of `or_patterns` feature rustup rust-lang/rust#69589 Rustup to rust-lang/rust#69076 Don't convert Path to lossy str Use `into_path` Use pattern matching instead of manually checking condition Fix typo Remove git2 dependency. Document that wildcard_imports doesn't warn about `use ...::prelude::*;` Change changelog formatting Update changelog_update doc to reflect the actual ordering of the changelog Update CHANGELOG.md ```` Fixes #70007

rust-highfive assigned Zoxc Feb 11, 2020

cjgillot force-pushed the split_trait branch from 81cfd11 to 5289587 Compare February 11, 2020 22:48

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2020

cjgillot force-pushed the split_trait branch from 5289587 to a89f80d Compare February 12, 2020 16:40

cjgillot force-pushed the split_trait branch from a89f80d to be162a6 Compare February 16, 2020 13:13

Zoxc mentioned this pull request Feb 16, 2020

Split librustc::{traits,infer} to a separate crate rustc_infer #67953

Merged

cjgillot force-pushed the split_trait branch from be162a6 to 2f9c45d Compare February 17, 2020 07:59

cjgillot changed the title ~~[WIP] Split librustc::{traits,infer} to their respective crates~~ Split librustc::{traits,infer} to their respective crates Feb 17, 2020

cjgillot mentioned this pull request Feb 17, 2020

Querify object_safety_violations. #69242

Merged

bors added a commit that referenced this pull request Feb 21, 2020

Auto merge of #69242 - cjgillot:object_violations, r=Zoxc

1d7e818

Querify object_safety_violations. Split from #69076 r? @Zoxc

rust-highfive assigned matthewjasper and unassigned Zoxc Feb 21, 2020

cjgillot force-pushed the split_trait branch from 2f9c45d to 9341592 Compare February 22, 2020 11:03

matthewjasper reviewed Feb 24, 2020

View reviewed changes

cjgillot force-pushed the split_trait branch from 78c368a to a9b2e0c Compare February 26, 2020 19:36

cjgillot force-pushed the split_trait branch from a9b2e0c to d042f5c Compare February 28, 2020 08:08

cjgillot force-pushed the split_trait branch from d042f5c to 65601f3 Compare February 28, 2020 18:38

rust-highfive mentioned this pull request Mar 14, 2020

clippy-driver no longer builds after rust-lang/rust#69076 #70007

Closed

JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Mar 14, 2020

Rustup to rust-lang/rust#69076

00861d1

bors added a commit to rust-lang/rust-clippy that referenced this pull request Mar 14, 2020

Auto merge of #5317 - JohnTitor:rustup, r=matthiaskrgr

8fd7e31

Rustup to rust-lang/rust#69076 changelog: none

cjgillot deleted the split_trait branch March 15, 2020 09:00

Uh oh!

Conversation

cjgillot commented Feb 11, 2020

Uh oh!

bors commented Feb 12, 2020

Uh oh!

bors commented Feb 12, 2020

Uh oh!

bors commented Feb 17, 2020

Uh oh!

Zoxc commented Feb 17, 2020

Uh oh!

Zoxc commented Feb 17, 2020

Uh oh!

Zoxc commented Feb 21, 2020

Uh oh!

matthewjasper Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

cjgillot Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

Zoxc Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

bors commented Feb 26, 2020

Uh oh!

petrochenkov commented Feb 26, 2020

Uh oh!

bors commented Feb 28, 2020

Uh oh!

bors commented Feb 28, 2020

Uh oh!

bors commented Feb 28, 2020

Uh oh!

rust-highfive commented Mar 14, 2020

Uh oh!

nnethercote commented Apr 8, 2020

Uh oh!

Zoxc commented Apr 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants