Closed
Conversation
This might spare someone else a little time searching the stdlib for unicode/grapheme support.
s/for reads and writes/for both ...
Added missing condition: `dst` must be readable
For all methods which read a value of type T, `read`, `read_unaligned`, `read_volatile` and `replace`, added missing constraint: The value they point to must be properly initialized
Added missing conditions: - Valid for writes - Valid for destructing
Updating str.chars docs to mention crates.io. This might spare someone else a little time searching the stdlib for unicode/grapheme support.
Improve #Safety of various methods in core::ptr For `read`, `read_unaligned`,`read_volatile`, `replace`, and `drop_in_place`: - The value they point to must be properly initialized For `replace`, additionally: - The pointer must be readable
macOS: avoid calling pthread_self() twice
Rename `FunctionRetTy` to `FnRetTy` As per FIXME comment r? @Centril
[tiny] parser: `macro_rules` is a weak keyword r? @Centril
…lan-DPC Clean up E0309 explanation r? @Dylan-DPC
…acrum debug_assert a few more raw pointer methods Fixes rust-lang#53871
Member
Author
|
@bors r+ p=7 rollup=never |
Collaborator
|
📌 Commit 1dafcce has been approved by |
Collaborator
|
⌛ Testing commit 1dafcce with merge 0370cef186fc1a2dd44305b16234ec551d4ad408... |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
FunctionRetTytoFnRetTy#69179 (RenameFunctionRetTytoFnRetTy)macro_rulesis a weak keyword #69186 ([tiny] parser:macro_rulesis a weak keyword)Failed merges:
r? @ghost