Revert u8to64_le changes from #68914.#69332
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 22, 2020
Merged
Conversation
`SipHasher128`'s `u8to64_le` function was simplified in rust-lang#68914. Unfortunately, the new version is slower, because it introduces `memcpy` calls with non-statically-known lengths. This commit reverts the change, and adds an explanatory comment (which is also added to `libcore/hash/sip.rs`). This barely affects `SipHasher128`'s speed because it doesn't use `u8to64_le` much, but it does result in `SipHasher128` once again being consistent with `libcore/hash/sip.rs`.
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ |
Collaborator
|
📌 Commit 100ff5a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 2, 2020
…k-Simulacrum Toolstate: Don't block beta week on already broken tools. This changes it so that tools are allowed to be broken entering the beta week if they are already broken. This restores the original behavior before the changes in rust-lang#69332. Closes rust-lang#68458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SipHasher128'su8to64_lefunction was simplified in #68914.Unfortunately, the new version is slower, because it introduces
memcpycalls with non-statically-known lengths.
This commit reverts the change, and adds an explanatory comment (which
is also added to
libcore/hash/sip.rs). This barely affectsSipHasher128's speed because it doesn't useu8to64_lemuch, but itdoes result in
SipHasher128once again being consistent withlibcore/hash/sip.rs.r? @michaelwoerister