Use query to determine whether function needs const checking#69642
Use query to determine whether function needs const checking#69642bors merged 3 commits intorust-lang:masterfrom
Conversation
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Not sure what's up with the diagnostics changes. I assume that invoking |
|
Some (I haven't checked all of them) of the additional errors look to me like they would happen if the other errors didn't happen before, so maybe this is just a case of some queries being triggered that would have otherwise not gotten triggered at all because of errors happening before them? |
|
You can check this by looking at the query stack with |
|
☔ The latest upstream changes (presumably #68944) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@ecstatic-morse any updates? also you have a conflict to resolve :) |
313d456 to
eb74096
Compare
|
@oli-obk I preserved the existing query order by calling |
|
@bors r+ |
|
📌 Commit eb74096 has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#69642 (Use query to determine whether function needs const checking) - rust-lang#71239 (Rename `asm` test directory in favor of `llvm_asm`) - rust-lang#71246 (Implement `Clone` for `liballoc::collections::linked_list::Cursor`.) - rust-lang#71247 (Remove unnecessary variable intialization) - rust-lang#71254 (Minor fix and addition to doc comments) Failed merges: r? @ghost
Resolves #69615.
The HIR const-checker was checking the
constnessof a function'sfn_sigto determine whether a function needed const-checking. Now that const trait impls are a thing, this is no longer enough. All code should use theis_const_fn_rawquery instead, which takes the constness of the impl block into account.r? @oli-obk