Extend E0308 description with dynamic dispatch example by llogiq · Pull Request #70071 · rust-lang/rust

llogiq · 2020-03-17T07:30:53Z

rust-highfive · 2020-03-17T07:49:47Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-17T07:31:27.2154332Z ========================== Starting Command Output ===========================
2020-03-17T07:31:27.2156839Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/930ab6df-6791-4925-938c-93fd99bf4c08.sh
2020-03-17T07:31:27.2157101Z 
2020-03-17T07:31:27.2161439Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-17T07:31:27.2191222Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70071/merge to s
2020-03-17T07:31:27.2194488Z Task         : Get sources
2020-03-17T07:31:27.2194788Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T07:31:27.2195065Z Version      : 1.0.0
2020-03-17T07:31:27.2195251Z Author       : Microsoft
---
2020-03-17T07:31:30.5113102Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-17T07:31:30.5120389Z ##[command]git config gc.auto 0
2020-03-17T07:31:30.5125014Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-17T07:31:30.5128437Z ##[command]git config --get-all http.proxy
2020-03-17T07:31:30.5136066Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70071/merge:refs/remotes/pull/70071/merge
---
2020-03-17T07:38:26.1089751Z    Compiling serde_json v1.0.40
2020-03-17T07:38:27.6759475Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2020-03-17T07:38:37.5663419Z     Finished release [optimized] target(s) in 1m 20s
2020-03-17T07:38:37.5761809Z tidy check
2020-03-17T07:38:38.4511656Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:28: tab character
2020-03-17T07:38:38.4512202Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:30: tab character
2020-03-17T07:38:38.4512719Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:31: line longer than 80 chars
2020-03-17T07:38:38.4513276Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:31: tab character
2020-03-17T07:38:38.4513764Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:54: tab character
2020-03-17T07:38:38.4514251Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:55: tab character
2020-03-17T07:38:38.4514755Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:57: tab character
2020-03-17T07:38:38.4515494Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0308.md:58: tab character
2020-03-17T07:38:40.3460239Z Found 489 error codes
2020-03-17T07:38:40.3460553Z Found 0 error codes with no tests
2020-03-17T07:38:40.3460814Z Done!
2020-03-17T07:38:40.3460999Z some tidy checks failed
2020-03-17T07:38:40.3460999Z some tidy checks failed
2020-03-17T07:38:40.3461156Z 
2020-03-17T07:38:40.3461266Z 
2020-03-17T07:38:40.3462956Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-03-17T07:38:40.3464288Z 
2020-03-17T07:38:40.3464418Z 
2020-03-17T07:38:40.3470791Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-03-17T07:38:40.3471208Z Build completed unsuccessfully in 0:01:31
2020-03-17T07:38:40.3471208Z Build completed unsuccessfully in 0:01:31
2020-03-17T07:38:40.3520768Z == clock drift check ==
2020-03-17T07:38:40.3547163Z   local time: Tue Mar 17 07:38:40 UTC 2020
2020-03-17T07:38:40.6423572Z   network time: Tue, 17 Mar 2020 07:38:40 GMT
2020-03-17T07:38:40.6431020Z == end clock drift check ==
2020-03-17T07:38:41.4188617Z 
2020-03-17T07:38:41.4282488Z ##[error]Bash exited with code '1'.
2020-03-17T07:38:41.4296753Z ##[section]Finishing: Run build
2020-03-17T07:38:41.4370679Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70071/merge to s
2020-03-17T07:38:41.4376614Z Task         : Get sources
2020-03-17T07:38:41.4377101Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T07:38:41.4377554Z Version      : 1.0.0
2020-03-17T07:38:41.4377871Z Author       : Microsoft
2020-03-17T07:38:41.4377871Z Author       : Microsoft
2020-03-17T07:38:41.4378355Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-17T07:38:41.4378951Z ==============================================================================
2020-03-17T07:38:41.7895297Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-17T07:38:41.7952651Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70071/merge to s
2020-03-17T07:38:41.8049591Z Cleaning up task key
2020-03-17T07:38:41.8051158Z Start cleaning up orphan processes.
2020-03-17T07:38:41.8395702Z Terminate orphan process: pid (3948) (python)
2020-03-17T07:38:41.8433568Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

src/librustc_error_codes/error_codes/E0308.md

rust-highfive · 2020-03-17T18:20:02Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-17T18:01:41.0902806Z ========================== Starting Command Output ===========================
2020-03-17T18:01:41.0907109Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/9f8b829b-8892-4b2a-a7eb-8fec941a9eb3.sh
2020-03-17T18:01:41.0907414Z 
2020-03-17T18:01:41.0912000Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-17T18:01:41.0932456Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70071/merge to s
2020-03-17T18:01:41.0935944Z Task         : Get sources
2020-03-17T18:01:41.0936268Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T18:01:41.0936583Z Version      : 1.0.0
2020-03-17T18:01:41.0936816Z Author       : Microsoft
---
2020-03-17T18:01:42.0800298Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-17T18:01:42.0806146Z ##[command]git config gc.auto 0
2020-03-17T18:01:42.0810339Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-17T18:01:42.0814187Z ##[command]git config --get-all http.proxy
2020-03-17T18:01:42.0821446Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70071/merge:refs/remotes/pull/70071/merge
---
2020-03-17T18:07:36.6438311Z Done!
2020-03-17T18:07:36.6438610Z some tidy checks failed
2020-03-17T18:07:36.6442344Z 
2020-03-17T18:07:36.6442646Z 
2020-03-17T18:07:36.6444070Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-03-17T18:07:36.6445137Z 
2020-03-17T18:07:36.6445340Z 
2020-03-17T18:07:36.6451025Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-03-17T18:07:36.6451622Z Build completed unsuccessfully in 0:01:30
2020-03-17T18:07:36.6451622Z Build completed unsuccessfully in 0:01:30
2020-03-17T18:07:36.6498094Z == clock drift check ==
2020-03-17T18:07:36.6518590Z   local time: Tue Mar 17 18:07:36 UTC 2020
2020-03-17T18:07:36.8133754Z   network time: Tue, 17 Mar 2020 18:07:36 GMT
2020-03-17T18:07:36.8134886Z == end clock drift check ==
2020-03-17T18:07:37.6848373Z 
2020-03-17T18:07:37.6939497Z ##[error]Bash exited with code '1'.
2020-03-17T18:07:37.6957135Z ##[section]Finishing: Run build
2020-03-17T18:07:37.7004351Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70071/merge to s
2020-03-17T18:07:37.7009635Z Task         : Get sources
2020-03-17T18:07:37.7010041Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T18:07:37.7010403Z Version      : 1.0.0
2020-03-17T18:07:37.7010874Z Author       : Microsoft
2020-03-17T18:07:37.7010874Z Author       : Microsoft
2020-03-17T18:07:37.7012603Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-17T18:07:37.7013088Z ==============================================================================
2020-03-17T18:07:38.0724391Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-17T18:07:38.0769306Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70071/merge to s
2020-03-17T18:07:38.0875340Z Cleaning up task key
2020-03-17T18:07:38.0876688Z Start cleaning up orphan processes.
2020-03-17T18:07:38.1095370Z Terminate orphan process: pid (4076) (python)
2020-03-17T18:07:38.1240145Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

llogiq · 2020-03-18T00:59:52Z

Hmm...it appears the error text is included in some ui tests. Will update tomorrow.

bors · 2020-03-19T03:50:53Z

☔ The latest upstream changes (presumably #70118) made this pull request unmergeable. Please resolve the merge conflicts.

llogiq · 2020-03-20T06:55:48Z

I'm unsure how to fix the numeric-suffix test, there appears to be an error in compiletest.

llogiq · 2020-03-23T20:16:01Z

@GuilliaumeGomez it appears that this uncovers some breakage in compiletest? Haven't debugged yet, because I didn't compile with debug info yet.

bors · 2020-03-24T04:18:16Z

☔ The latest upstream changes (presumably #70343) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2020-03-30T15:30:46Z

This pretty nice except for the huge weird bug. Here's what I suggest: change which error code explanation is tested in src/test/ui/json-bom-plus-crlf.stderr so we can move forward on this PR. Unless @rust-lang/compiler has a reason to use this specific error code explanation?

nikomatsakis · 2020-04-01T14:19:58Z

Seems...fine to test some other random error. What's the bug exactly? Something in compiletest?

llogiq · 2020-04-04T06:20:01Z

I must assume so. Probably some JSON message cut in transit.

eddyb · 2020-04-04T09:37:35Z

I don't see any cutting. Furthermore, Cargo and other tools rely on parsing the same JSON.
Are you sure this won't cause issues?

llogiq · 2020-04-04T11:36:15Z

If so, then the error is only uncovered by this change, not caused by it. But I'll try bisecting the problem.

eddyb · 2020-04-04T14:29:40Z

If so, then the error is only uncovered by this change, not caused by it. But I'll try bisecting the problem.

Hmm if you can reproduce locally, I suppose you can try removing parts of your message until it goes away? I suspect it's some sequence of characters that doesn't escape properly?

llogiq · 2020-04-04T18:07:34Z

Yeah, that's the plan.

llogiq · 2020-04-10T14:52:33Z

I have finally found the time to bisect the problem. The thing works up to the last example reduced to:

use std::{io, fs, env};

let arg = env::args().nth(1).unwrap_or("-".into());

// We only declare, not initialize the values.
let (mut stdin, mut file);

If I only add another // empty comment at the end (which shouldn't make a difference here), the error occurs. This makes me suspect that I run into some strange size limitation.

eddyb · 2020-04-10T15:22:58Z

cc @rust-lang/wg-diagnostics

crlf0710 · 2020-05-08T12:56:45Z

@llogiq Ping from triage. Needs a rebase here. I'd actually suggest trying and see if there's some way to finish the error code description without triggering this issue locally, and file a separate issue about this at the same time.

estebank · 2020-05-08T15:02:32Z

The only thing that comes to mind is that multiline spans don't get fully rendered if they are longer than 7 lines... But I don't see how that would affect this.

Dylan-DPC-zz · 2020-05-27T19:26:13Z

Closing this due to inactivity.

rust-highfive assigned GuillaumeGomez Mar 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2020

Centril reviewed Mar 17, 2020

View reviewed changes

src/librustc_error_codes/error_codes/E0308.md Outdated Show resolved Hide resolved

src/librustc_error_codes/error_codes/E0308.md Outdated Show resolved Hide resolved

llogiq force-pushed the extend-E0308 branch from 2adbbd9 to 2f7aac8 Compare March 17, 2020 18:01

llogiq force-pushed the extend-E0308 branch from 2f7aac8 to 8216e7c Compare March 17, 2020 18:21

llogiq force-pushed the extend-E0308 branch from 8216e7c to 5b8ff8b Compare March 18, 2020 22:08

Extend E0308 description with dynamic dispatch example

bf29323

llogiq force-pushed the extend-E0308 branch from 5b8ff8b to bf29323 Compare March 19, 2020 19:05

joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2020

joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2020

Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2020

Dylan-DPC-zz closed this May 27, 2020

Uh oh!

Conversation

llogiq commented Mar 17, 2020

Uh oh!

rust-highfive commented Mar 17, 2020

Uh oh!

Uh oh!

Uh oh!

rust-highfive commented Mar 17, 2020

Uh oh!

llogiq commented Mar 18, 2020

Uh oh!

bors commented Mar 19, 2020

Uh oh!

llogiq commented Mar 20, 2020

Uh oh!

llogiq commented Mar 23, 2020

Uh oh!

bors commented Mar 24, 2020

Uh oh!

GuillaumeGomez commented Mar 30, 2020

Uh oh!

nikomatsakis commented Apr 1, 2020

Uh oh!

llogiq commented Apr 4, 2020

Uh oh!

eddyb commented Apr 4, 2020

Uh oh!

llogiq commented Apr 4, 2020

Uh oh!

eddyb commented Apr 4, 2020

Uh oh!

llogiq commented Apr 4, 2020

Uh oh!

llogiq commented Apr 10, 2020

Uh oh!

eddyb commented Apr 10, 2020

Uh oh!

crlf0710 commented May 8, 2020

Uh oh!

estebank commented May 8, 2020

Uh oh!

Dylan-DPC-zz commented May 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants