Merged
Conversation
Namely, this version focuses on the end-to-end behavior that the attempt to create the UDP binding will fail, regardless of the semantics of how particular DNS servers handle junk inputs. (I spent some time trying to create a second more-focused test that would sidestep the DNS resolution, but this is not possible without more invasive changes to the internal infrastructure of `ToSocketAddrs` and what not. It is not worth it.)
Also stop encoding/decoding it entirely
…r=nikomatsakis symbol_names: treat ReifyShim like VtableShim. Without this, the `#[track_caller]` tests don't pass with `-Zsymbol-mangling-version=v0`, because there is a symbol name collision between the `ReifyShim` and the original definition. cc @anp
Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb
…um_discr, r=RalfJung,eddyb Fix ICE caused by truncating a negative ZST enum discriminant Fixes rust-lang#70114 r? @oli-obk or @RalfJung
…-23076, r=LukasKalbertodt For issue 53957: revise unit test to focus on underlying bug of 23076. Fix rust-lang#53957 by revising unit test to focus on underlying bug of rust-lang#23076. Namely, this version focuses on the end-to-end behavior that the attempt to create the UDP binding will fail, regardless of the semantics of how particular DNS servers handle junk inputs. (I spent some time trying to create a second more-focused test that would sidestep the DNS resolution, but this is not possible without more invasive changes to the internal infrastructure of `ToSocketAddrs` and what not. It is not worth it.)
ast: Compress `AttrId` from `usize` to `u32` An easy size win for `ast::Attribute` (96 bytes -> 88 bytes). Also stop encoding/decoding `AttrId` entirely.
…, r=jonas-schievink Fix deprecated Error.description() usage in docs
Remove CARGO_BUILD_TARGET from bootstrap.py Closes rust-lang#70208
Add explanation message for E0224 Addresses some of rust-lang#61137
Tweak wording for std::io::Read::read function I think the sentence as a whole reads smoother that way.
Add a test for out-of-line module passed through a proc macro Closes rust-lang#58818.
Author
|
@bors r+ rollup=never p=10 |
Collaborator
|
📌 Commit 17e6ed1 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
hir().findto returnNone#70051 (Allowhir().findto returnNone)AttrIdfromusizetou32#70215 (ast: CompressAttrIdfromusizetou32)Failed merges:
r? @ghost