Make our pattern matching logic undestand &[T] constants#70699
Closed
oli-obk wants to merge 3 commits intorust-lang:masterfrom
Closed
Make our pattern matching logic undestand &[T] constants#70699oli-obk wants to merge 3 commits intorust-lang:masterfrom
&[T] constants#70699oli-obk wants to merge 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
reviewed
Apr 2, 2020
| // Deref of a reference to a ZST is a nop. | ||
| ConstValue::Scalar(Scalar::zst()) | ||
| } else { | ||
| // FIXME(oli-obk): this is reachable for `const FOO: &&&u32 = &&&42;` |
Contributor
There was a problem hiding this comment.
Was this comment incorrect before?
Contributor
Author
There was a problem hiding this comment.
apparently, we have a test for this, but the ICE is a different one somewhere in the middle of pattern matching. I've so far been unable to figure it out.
Co-Authored-By: varkor <github@varkor.com>
Centril
reviewed
Apr 2, 2020
| (ConstValue::Scalar(Scalar::Ptr(p)), ty::Array(t, n), ty::Slice(u)) => { | ||
| // Unsize array to slice if pattern is array | ||
| // but match value or other patterns are slice. | ||
| (ConstValue::Scalar(s), ty::Array(t, n), ty::Slice(u)) => { |
Contributor
There was a problem hiding this comment.
Would be good to avoid these one-letter variable names.
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
Author
|
I found a rabbit hole and wrote some text about it: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/constants.20in.20patterns/near/192783049 I want to fix this once and for all, instead of the piecemeal thing that I've been doing the last years. |
Contributor
Author
|
closing in favour of #70743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should generalize this to other types, too, so treat this as a proof of concept.