Rollup of 4 pull requests#71245
Closed
Dylan-DPC-zz wants to merge 11 commits intorust-lang:masterfrom
Closed
Conversation
The `FnAbi` now knows if the function is allowed to unwind. If a function isn't allowed to unwind, we can use a `call` instead of an `invoke`. This resolves an issue when calling LLVM intrinsics which cannot unwind LLVM will generate an error if you attempt to invoke them so we need to ignore cleanup blocks in codegen and generate a call instead.
Use `call` instead of `invoke` for functions that cannot unwind The `FnAbi` now knows if the function is allowed to unwind. If a function isn't allowed to unwind, we can use a `call` instead of an `invoke`. This resolves an issue when calling LLVM intrinsics which cannot unwind LLVM will generate an error if you attempt to invoke them so we need to ignore cleanup blocks in codegen and generate a call instead. Fixes rust-lang#69911 r? @eddyb cc @rust-lang/wg-ffi-unwind
…dle-local-def-id-2, r=eddyb Simplify `local_def_id` and `as_local_hir_id`
Rename `asm` test directory in favor of `llvm_asm` r? @Amanieu
Format Mailmap To Work With GitHub r? @Mark-Simulacrum
Author
|
@bors r+ p=4 rollup=never |
Collaborator
|
📌 Commit 7461e3a has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 7461e3a with merge 712a92c159ee1f4f71a13bc6e48762ed9d0d6c5b... |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Collaborator
|
⌛ Testing commit 7461e3a with merge 3d88648d9d391a339757848e6667260c21d23bc3... |
Author
|
@bors r- |
bors
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
callinstead ofinvokefor functions that cannot unwind #70467 (Usecallinstead ofinvokefor functions that cannot unwind )local_def_idandas_local_hir_id#71215 (Simplifylocal_def_idandas_local_hir_id)asmtest directory in favor ofllvm_asm#71239 (Renameasmtest directory in favor ofllvm_asm)Failed merges:
r? @ghost