Suggest adding super trait constraints#71451
Merged
bors merged 4 commits intorust-lang:masterfrom May 13, 2020
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
The first commit is the only logic change. The second change only changes the output to be more verbose and clear. |
crlf0710
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
suggest-super-trait-constraint
branch
from
9ed0197 to
cbaff49
Compare
Contributor
Author
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
suggest-super-trait-constraint
branch
from
cbaff49 to
9c539dc
Compare
nikomatsakis
approved these changes
May 11, 2020
src/librustc_trait_selection/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
src/librustc_trait_selection/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
src/librustc_trait_selection/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
Contributor
|
r=me with nits |
nikomatsakis
added
S-waiting-on-author
- Make the bound restriction suggestion `span_suggestion_verbose`. - Fix whitespace typo.
estebank
force-pushed
the
suggest-super-trait-constraint
branch
from
9c539dc to
58797b0
Compare
Contributor
Author
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit 58797b0 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced May 13, 2020
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.