Don't add attribute to allow unused-qualifications to derive impl's#71969
Closed
samrat wants to merge 1 commit intorust-lang:masterfrom
Closed
Don't add attribute to allow unused-qualifications to derive impl's#71969samrat wants to merge 1 commit intorust-lang:masterfrom
samrat wants to merge 1 commit intorust-lang:masterfrom
Conversation
Currently `#![forbid(unused_qualifications)]` is incompatible with all derive's because we add `#[allow(unused_qualifications)]` in all generated impl's.
Contributor
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Collaborator
|
☔ The latest upstream changes (presumably #72041) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@rustbot modify labels to +S-waiting-on-author -S-waiting-on-review |
rustbot
added
S-waiting-on-author
Contributor
|
r? @varkor |
Contributor
|
The |
Contributor
|
Ping from triage: @samrat |
Elinvynia
added
S-waiting-on-author
Member
|
Another ping from triage @samrat |
|
@samrat closing this pr due to inactivity. If you have time again, you can open a new pr with these changes. Thanks for taking the time to contribute :) |
Dylan-DPC-zz
added
S-inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
#![forbid(unused_qualifications)]is incompatible with all derive's because we add#[allow(unused_qualifications)]in all generated impl's.Closes #71898