Spell out `Self` in async function return by csmoe · Pull Request #72260 · rust-lang/rust

csmoe · 2020-05-16T09:07:57Z

Closes #69276
r? @tmandry

rust-highfive · 2020-05-16T09:07:59Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

src/librustc_typeck/check/mod.rs

tmandry · 2020-05-21T01:47:27Z

Looks good, thanks!

@bors r+

bors · 2020-05-21T01:47:28Z

📌 Commit 2f311b0 has been approved by tmandry

@tmandry

Spell out `Self` in async function return Closes rust-lang#69276 r? @tmandry

RalfJung · 2020-05-21T19:06:53Z

Failed in #72430 (comment)

tidy check
tidy error: duplicate error code: 755
tidy error: /checkout/src/librustc_error_codes/error_codes.rs:440: E0755: include_str!("./error_codes/E0755.md"),
tidy error: /checkout/src/librustc_error_codes/error_codes.rs:620:     E0755, // `#[ffi_pure]` is only allowed on foreign functions
Checking which error codes lack tests...
some tidy checks failed
Found 496 error codes
Found 0 error codes with no tests
Done!

@bors r-

csmoe · 2020-05-22T08:18:28Z

r? @RalfJung
error codes updated

RalfJung · 2020-05-22T08:24:49Z

Sorry, I can't review this, I don't know the code. I just saw a failure during a rollup.
r? @tmandry

csmoe · 2020-05-29T14:27:19Z

@tmandry ping

csmoe · 2020-06-03T03:25:49Z

This PR was approved, but dequeued from the merging list as error-code conflict.
r? @estebank

estebank · 2020-06-03T18:53:39Z

@csmoe there's another PR that has taken E0758 already (and I have one open for E0759). Update and I'll r+

csmoe · 2020-06-04T01:39:09Z

@estebank moved to E0760.

estebank · 2020-06-05T01:51:06Z

@bors r+

bors · 2020-06-05T01:51:07Z

📌 Commit 9be6353 has been approved by estebank

@tmandry

Spell out `Self` in async function return Closes rust-lang#69276 r? @tmandry

@tmandry

Spell out `Self` in async function return Closes rust-lang#69276 r? @tmandry

@ghost

Rollup of 5 pull requests Successful merges: - rust-lang#72260 (Spell out `Self` in async function return) - rust-lang#72996 (Remove unsused `NodeId` related APIs in hir map) - rust-lang#73010 (Update RELEASES.md) - rust-lang#73017 (Use assert_eq for liballoc test) - rust-lang#73019 (add test for rust-lang#72960) Failed merges: r? @ghost

csmoe added 3 commits May 12, 2020 20:57

add ui test for issue-69276

29a41f0

create error code E0754

008d90a

suggest on Self return type

633e4aa

rust-highfive assigned tmandry May 16, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2020

csmoe requested a review from GuillaumeGomez May 16, 2020 09:08

csmoe force-pushed the issue-69276 branch 3 times, most recently from 8a64343 to 755ca01 Compare May 16, 2020 09:22

This comment has been minimized.

Sign in to view

csmoe force-pushed the issue-69276 branch 3 times, most recently from 0c314b9 to 142b1d3 Compare May 16, 2020 11:59

This comment has been minimized.

Sign in to view

bless suggestion on spell out

8841ede

csmoe force-pushed the issue-69276 branch 3 times, most recently from 84f6b27 to 2d9c166 Compare May 18, 2020 01:06

tmandry reviewed May 18, 2020

View reviewed changes

src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved

src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved

Merge branch 'master' into issue-69276

2f311b0

csmoe force-pushed the issue-69276 branch from 2d9c166 to 2f311b0 Compare May 19, 2020 03:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2020

RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020

Rollup merge of rust-lang#72260 - csmoe:issue-69276, r=tmandry

0aecafa

Spell out `Self` in async function return Closes rust-lang#69276 r? @tmandry

RalfJung mentioned this pull request May 21, 2020

Rollup of 7 pull requests #72430

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 21, 2020

rust-highfive assigned RalfJung and unassigned tmandry May 22, 2020

rust-highfive assigned tmandry and unassigned RalfJung May 22, 2020

rust-highfive assigned estebank and unassigned tmandry Jun 3, 2020

resolve error code e0760

9be6353

csmoe force-pushed the issue-69276 branch from 9e3b2bc to 9be6353 Compare June 4, 2020 01:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020

Rollup merge of rust-lang#72260 - csmoe:issue-69276, r=estebank

96ca604

Spell out `Self` in async function return Closes rust-lang#69276 r? @tmandry

Dylan-DPC-zz mentioned this pull request Jun 5, 2020

Rollup of 5 pull requests #73018

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020

Rollup merge of rust-lang#72260 - csmoe:issue-69276, r=estebank

9fcc7b8

Spell out `Self` in async function return Closes rust-lang#69276 r? @tmandry

This was referenced Jun 5, 2020

Rollup of 4 pull requests #73024

Closed

Rollup of 5 pull requests #73025

Merged

bors merged commit 14dc34d into rust-lang:master Jun 5, 2020

Uh oh!

Conversation

csmoe commented May 16, 2020

Uh oh!

rust-highfive commented May 16, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

tmandry commented May 21, 2020

Uh oh!

bors commented May 21, 2020

Uh oh!

RalfJung commented May 21, 2020

Uh oh!

csmoe commented May 22, 2020

Uh oh!

RalfJung commented May 22, 2020

Uh oh!

csmoe commented May 29, 2020

Uh oh!

csmoe commented Jun 3, 2020

Uh oh!

estebank commented Jun 3, 2020

Uh oh!

csmoe commented Jun 4, 2020

Uh oh!

estebank commented Jun 5, 2020

Uh oh!

bors commented Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants