Replace obligation construction with deref_steps()#72292
Merged
bors merged 1 commit intorust-lang:masterfrom May 23, 2020
Merged
Replace obligation construction with deref_steps()#72292bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
Collaborator
|
☔ The latest upstream changes (presumably #72433) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 407958a has been approved by |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 23, 2020
Replace obligation construction with deref_steps() 1. Use `probe()` to avoid unwanted binding committing during `deref_steps()`. 2. Fixes rust-lang#59819 again by using `deref_steps()`, make the code cleaner. And if we want to suggest multiple dereferences (like: `consider dereferencing the borrow: "****a"`) in the future, this change will make it easier to achieve.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 23, 2020
Replace obligation construction with deref_steps() 1. Use `probe()` to avoid unwanted binding committing during `deref_steps()`. 2. Fixes rust-lang#59819 again by using `deref_steps()`, make the code cleaner. And if we want to suggest multiple dereferences (like: `consider dereferencing the borrow: "****a"`) in the future, this change will make it easier to achieve.
This was referenced May 23, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72292 (Replace obligation construction with deref_steps()) - rust-lang#72431 (add warning sign to UB examples) - rust-lang#72446 (Impl Ord for proc_macro::LineColumn) - rust-lang#72492 (Add some regression tests) - rust-lang#72496 (Correct small typo: 'not' -> 'note') Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probe()to avoid unwanted binding committing duringderef_steps().Dereftypes other than references is missing suggestion #59819 again by usingderef_steps(), make the code cleaner. And if we want to suggest multiple dereferences (like:consider dereferencing the borrow: "****a") in the future, this change will make it easier to achieve.