Added detailed error code explanation for issue E0688 in Rust compiler.#72654
Closed
Polkaverse wants to merge 1 commit intorust-lang:masterfrom
Polkaverse:ErrorCode-E0688
Closed
Added detailed error code explanation for issue E0688 in Rust compiler.#72654Polkaverse wants to merge 1 commit intorust-lang:masterfrom Polkaverse:ErrorCode-E0688
Polkaverse wants to merge 1 commit intorust-lang:masterfrom
Polkaverse:ErrorCode-E0688
Conversation
Contributor
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
Elinvynia
added
S-waiting-on-review
Contributor
Author
|
r? @davidtwco |
davidtwco
requested changes
Jun 20, 2020
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Apologies for how long it's taken for this to be reviewed!
| @@ -0,0 +1,36 @@ | |||
| In-band lifetimes has mixed with explicit lifetime binders. | |||
Member
There was a problem hiding this comment.
Suggested change
| In-band lifetimes has mixed with explicit lifetime binders. | |
| In-band lifetimes were mixed with explicit lifetime binders. |
| } | ||
| ``` | ||
|
|
||
| We cannot mix in-band lifetimes with explicit lifetime binders. |
Member
There was a problem hiding this comment.
Suggested change
| We cannot mix in-band lifetimes with explicit lifetime binders. | |
| In-band lifetimes cannot be mixed with explicit lifetime binders. |
This is really just a re-phrasing of the error, it'd be great to elaborate a little - something like "a function/struct/whatever can either have explicit lifetime binders or in-band lifetimes".
| For example: | ||
|
|
||
| ``` | ||
| fn foo<'a, 'b>(x: &'a u32, y: &'b u32) {} // ok! |
Member
There was a problem hiding this comment.
I'd also add another example where only in-band lifetimes are used (with a short sentence before each example explaining how they differ).
Collaborator
|
☔ The latest upstream changes (presumably #73924) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added proper error explanation for issue E0688 in the Rust compiler.
Error Code E0688
Sub Part of Issue #61137
r? @GuillaumeGomez