Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @tmandry |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
We want to avoid exporting any symbols from Rust's version of libunwind, and to do so we need to disable visibility annotations to make sure that the -fvisibility=hidden has effect, and also hide global new/delete. This matches the CMake build of libunwind.
88eebff to
21abc88
Compare
|
@bors r+ rollup=never |
|
📌 Commit 21abc88 has been approved by |
|
@bors p=1 |
As asked previously, why don't you just use CMake to do the build? That avoids having to maintain a separate build flow. |
|
☀️ Test successful - checks-azure |
We want to avoid exporting any symbols from Rust's version of libunwind,
and to do so we need to disable visibility annotations to make sure that
the -fvisibility=hidden has effect, and also hide global new/delete.
This matches the CMake build of libunwind.