[DO NOT MERGE] Revert "WF-check all ty::Const's, not just array lengths."#73045
Closed
lcnr wants to merge 1 commit intorust-lang:masterfrom
Closed
[DO NOT MERGE] Revert "WF-check all ty::Const's, not just array lengths."#73045lcnr wants to merge 1 commit intorust-lang:masterfrom
lcnr wants to merge 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
@rust-timer queue @bors try |
Collaborator
|
⌛ Trying commit 26dfd86 with merge 8db9e9bb497ce0b30e28b780f4412393c396d40f... |
Collaborator
|
☀️ Try build successful - checks-azure |
Contributor
|
@rust-timer queue 8db9e9bb497ce0b30e28b780f4412393c396d40f |
Member
|
@rust-timer build 8db9e9bb497ce0b30e28b780f4412393c396d40f |
Collaborator
|
Queued 8db9e9bb497ce0b30e28b780f4412393c396d40f with parent e412475, future comparison URL. |
Collaborator
|
Finished benchmarking try commit (8db9e9bb497ce0b30e28b780f4412393c396d40f): comparison url. |
Contributor
|
It looks like reverting this makes very little difference 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checking for a perf regression noted in #70107 (comment)
Let's see if this automated revert passes CI before starting perf.
r? @Mark-Simulacrum